Unverified Commit a0ac82cb authored by Haoxiang Li's avatar Haoxiang Li Committed by Arnd Bergmann
Browse files

clk: spear: fix resource leak in clk_register_vco_pll() 



Add a goto label in clk_register_vco_pll(), unregister vco_clk
if tpll_clk is failed to be registered.

Signed-off-by: default avatarHaoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/r/20260325062204.169648-1-lihaoxiang@isrc.iscas.ac.cn


Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent c7091fd5

drivers/clk/spear/clk-vco-pll.c

+3 −1
Original line number Diff line number Diff line
@@ -343,13 +343,15 @@ struct clk *clk_register_vco_pll(const char *vco_name, const char *pll_name, 


	tpll_clk = clk_register(NULL, &pll->hw);

	if (IS_ERR_OR_NULL(tpll_clk))

		goto free_pll;

		goto unregister_clk;



	if (pll_clk)

		*pll_clk = tpll_clk;



	return vco_clk;



unregister_clk:

	clk_unregister(vco_clk);

free_pll:

	kfree(pll);

free_vco: