Unverified Commit a0ffa811 authored by Ricardo Rivera-Matos's avatar Ricardo Rivera-Matos Committed by Mark Brown
Browse files

ASoC: cs35l45: Prevents spinning during runtime suspend 



Masks the "DSP Virtual Mailbox 2 write" interrupt when before
issuing the hibernate command to the DSP. The interrupt is
unmasked when exiting runtime suspend as it is required for
DSP operation.

Without this change the DSP fires an interrupt when hibernating
causing the system spin between runtime suspend and runtime
resume.

Signed-off-by: default avatarRicardo Rivera-Matos <rriveram@opensource.cirrus.com>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20231206160318.1255034-4-rriveram@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c3c8b088

sound/soc/codecs/cs35l45.c

+4 −0
Original line number Diff line number Diff line
@@ -947,6 +947,8 @@ static int cs35l45_enter_hibernate(struct cs35l45_private *cs35l45) 


	cs35l45_setup_hibernate(cs35l45);



	regmap_set_bits(cs35l45->regmap, CS35L45_IRQ1_MASK_2, CS35L45_DSP_VIRT2_MBOX_MASK);



	// Don't wait for ACK since bus activity would wake the device

	regmap_write(cs35l45->regmap, CS35L45_DSP_VIRT1_MBOX_1, CSPL_MBOX_CMD_HIBERNATE);
@@ -967,6 +969,8 @@ static int cs35l45_exit_hibernate(struct cs35l45_private *cs35l45) 
					  CSPL_MBOX_CMD_OUT_OF_HIBERNATE);

			if (!ret) {

				dev_dbg(cs35l45->dev, "Wake success at cycle: %d\n", j);

				regmap_clear_bits(cs35l45->regmap, CS35L45_IRQ1_MASK_2,

						 CS35L45_DSP_VIRT2_MBOX_MASK);

				return 0;

			}

			usleep_range(100, 200);