Commit a1495a21 authored by Yassine Oudjana's avatar Yassine Oudjana Committed by Wim Van Sebroeck
Browse files

watchdog: mediatek: Make sure system reset gets asserted in mtk_wdt_restart() 



Clear the IRQ enable bit of WDT_MODE before asserting software reset
in order to make TOPRGU issue a system reset signal instead of an IRQ.

Fixes: a44a4553 ("watchdog: Add driver for Mediatek watchdog")
Signed-off-by: default avatarYassine Oudjana <y.oudjana@protonmail.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20241106104738.195968-2-y.oudjana@protonmail.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent f6fe9b62

drivers/watchdog/mtk_wdt.c

+6 −0
Original line number Diff line number Diff line
@@ -225,9 +225,15 @@ static int mtk_wdt_restart(struct watchdog_device *wdt_dev, 
{

	struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);

	void __iomem *wdt_base;

	u32 reg;



	wdt_base = mtk_wdt->wdt_base;



	/* Enable reset in order to issue a system reset instead of an IRQ */

	reg = readl(wdt_base + WDT_MODE);

	reg &= ~WDT_MODE_IRQ_EN;

	writel(reg | WDT_MODE_KEY, wdt_base + WDT_MODE);



	while (1) {

		writel(WDT_SWRST_KEY, wdt_base + WDT_SWRST);

		mdelay(5);