Commit a150c68a authored by Ekansh Gupta's avatar Ekansh Gupta Committed by Greg Kroah-Hartman
Browse files

misc: fastrpc: Add missing dev_err newlines 



Few dev_err calls are missing newlines. This can result in unrelated
lines getting appended which might make logs difficult to understand.
Add trailing newlines to avoid this.

Signed-off-by: default avatarEkansh Gupta <quic_ekangupt@quicinc.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarCaleb Connolly <caleb.connolly@linaro.org>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20240705075900.424100-3-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f0f53369

drivers/misc/fastrpc.c

+5 −5
Original line number Diff line number Diff line
@@ -325,7 +325,7 @@ static void fastrpc_free_map(struct kref *ref) 
			err = qcom_scm_assign_mem(map->phys, map->size,

				&src_perms, &perm, 1);

			if (err) {

				dev_err(map->fl->sctx->dev, "Failed to assign memory phys 0x%llx size 0x%llx err %d",

				dev_err(map->fl->sctx->dev, "Failed to assign memory phys 0x%llx size 0x%llx err %d\n",

						map->phys, map->size, err);

				return;

			}
@@ -816,7 +816,7 @@ static int fastrpc_map_create(struct fastrpc_user *fl, int fd, 
		map->attr = attr;

		err = qcom_scm_assign_mem(map->phys, (u64)map->size, &src_perms, dst_perms, 2);

		if (err) {

			dev_err(sess->dev, "Failed to assign memory with phys 0x%llx size 0x%llx err %d",

			dev_err(sess->dev, "Failed to assign memory with phys 0x%llx size 0x%llx err %d\n",

					map->phys, map->size, err);

			goto map_err;

		}
@@ -1222,7 +1222,7 @@ static bool is_session_rejected(struct fastrpc_user *fl, bool unsigned_pd_reques 
		 * that does not support unsigned PD offload

		 */

		if (!fl->cctx->unsigned_support || !unsigned_pd_request) {

			dev_err(&fl->cctx->rpdev->dev, "Error: Untrusted application trying to offload to signed PD");

			dev_err(&fl->cctx->rpdev->dev, "Error: Untrusted application trying to offload to signed PD\n");

			return true;

		}

	}
@@ -1280,7 +1280,7 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, 
							&src_perms,

							fl->cctx->vmperms, fl->cctx->vmcount);

			if (err) {

				dev_err(fl->sctx->dev, "Failed to assign memory with phys 0x%llx size 0x%llx err %d",

				dev_err(fl->sctx->dev, "Failed to assign memory with phys 0x%llx size 0x%llx err %d\n",

					fl->cctx->remote_heap->phys, fl->cctx->remote_heap->size, err);

				goto err_map;

			}
@@ -1332,7 +1332,7 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, 
						(u64)fl->cctx->remote_heap->size,

						&src_perms, &dst_perms, 1);

		if (err)

			dev_err(fl->sctx->dev, "Failed to assign memory phys 0x%llx size 0x%llx err %d",

			dev_err(fl->sctx->dev, "Failed to assign memory phys 0x%llx size 0x%llx err %d\n",

				fl->cctx->remote_heap->phys, fl->cctx->remote_heap->size, err);

	}

err_map: