Commit a189f0ee authored by Dan Carpenter's avatar Dan Carpenter Committed by Luiz Augusto von Dentz
Browse files

Bluetooth: qca: Fix error code in qca_read_fw_build_info() 



Return -ENOMEM on allocation failure.  Don't return success.

Fixes: cda0d6a1 ("Bluetooth: qca: fix info leak when fetching fw build id")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent ea9e148c

drivers/bluetooth/btqca.c

+3 −1
Original line number Diff line number Diff line
@@ -136,8 +136,10 @@ static int qca_read_fw_build_info(struct hci_dev *hdev) 
	}



	build_label = kstrndup(&edl->data[1], build_lbl_len, GFP_KERNEL);

	if (!build_label)

	if (!build_label) {

		err = -ENOMEM;

		goto out;

	}



	hci_set_fw_info(hdev, "%s", build_label);