Commit a1dc62b0 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

greybus: core: verify major/minor number of greybus protocol

parent 543b8ed2

drivers/staging/greybus/core.c

+9 −1
Original line number Diff line number Diff line
@@ -385,7 +385,15 @@ struct greybus_device *greybus_new_module(struct device *parent, 
	version_major = manifest->header.version_major;

	version_minor = manifest->header.version_minor;



	// FIXME - check version major/minor here!

	/* Validate major/minor number */

	if ((version_major != GREYBUS_VERSION_MAJOR) ||

	    (version_minor != GREYBUS_VERSION_MINOR)) {

		dev_err(parent,

			"Invalid greybus versions, expected %d.%d, got %d.%d\n",

			GREYBUS_VERSION_MAJOR, GREYBUS_VERSION_MINOR,

			version_major, version_minor);

		goto error;

	}



	size -= sizeof(manifest->header);

	data += sizeof(manifest->header);