Commit a22c9dc2 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Bartosz Golaszewski
Browse files

gpiolib: avoid format string weakness in workqueue interface 



Using a string literal as a format string is a possible bug when the
string contains '%' characters:

drivers/gpio/gpiolib-cdev.c:2813:48: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
 2813 |         gdev->line_state_wq = alloc_ordered_workqueue(dev_name(&gdev->dev),
      |                                                       ^~~~~~~~~~~~~~~~~~~~
drivers/gpio/gpiolib-cdev.c:2813:48: note: treat the string as an argument to avoid this
 2813 |         gdev->line_state_wq = alloc_ordered_workqueue(dev_name(&gdev->dev),
      |                                                       ^
      |                                                       "%s",

Do as clang suggests and use a trivial "%s" format string.

Fixes: 7b9b77a8 ("gpiolib: add a per-gpio_device line state notification workqueue")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20241028142152.750650-1-arnd@kernel.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 4f61d7fd

drivers/gpio/gpiolib-cdev.c

+2 −2
Original line number Diff line number Diff line
@@ -2810,8 +2810,8 @@ int gpiolib_cdev_register(struct gpio_device *gdev, dev_t devt) 
	gdev->chrdev.owner = THIS_MODULE;

	gdev->dev.devt = MKDEV(MAJOR(devt), gdev->id);



	gdev->line_state_wq = alloc_ordered_workqueue(dev_name(&gdev->dev),

						      WQ_HIGHPRI);

	gdev->line_state_wq = alloc_ordered_workqueue("%s", WQ_HIGHPRI,

						      dev_name(&gdev->dev));

	if (!gdev->line_state_wq)

		return -ENOMEM;