Unverified Commit a31a4934 authored by Evgeny Pimenov's avatar Evgeny Pimenov Committed by Mark Brown
Browse files

ASoC: qcom: Fix sc7280 lpass potential buffer overflow 



Case values introduced in commit
5f78e1fb ("ASoC: qcom: Add driver support for audioreach solution")
cause out of bounds access in arrays of sc7280 driver data (e.g. in case
of RX_CODEC_DMA_RX_0 in sc7280_snd_hw_params()).

Redefine LPASS_MAX_PORTS to consider the maximum possible port id for
q6dsp as sc7280 driver utilizes some of those values.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 77d0ffef ("ASoC: qcom: Add macro for lpass DAI id's max limit")
Cc: stable@vger.kernel.org # v6.0+
Suggested-by: default avatarMikhail Kobuk <m.kobuk@ispras.ru>
Suggested-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarEvgeny Pimenov <pimenoveu12@gmail.com>
Link: https://patch.msgid.link/20250401204058.32261-1-pimenoveu12@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2b727b3f

sound/soc/qcom/lpass.h

+2 −1
Original line number Diff line number Diff line
@@ -13,10 +13,11 @@ 
#include <linux/platform_device.h>

#include <linux/regmap.h>

#include <dt-bindings/sound/qcom,lpass.h>

#include <dt-bindings/sound/qcom,q6afe.h>

#include "lpass-hdmi.h"



#define LPASS_AHBIX_CLOCK_FREQUENCY		131072000

#define LPASS_MAX_PORTS			(LPASS_CDC_DMA_VA_TX8 + 1)

#define LPASS_MAX_PORTS			(DISPLAY_PORT_RX_7 + 1)

#define LPASS_MAX_MI2S_PORTS			(8)

#define LPASS_MAX_DMA_CHANNELS			(8)

#define LPASS_MAX_HDMI_DMA_CHANNELS		(4)