Commit a31e4518 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Helge Deller
Browse files

fbdev: udlfb: avoid divide-by-zero on FBIOPUT_VSCREENINFO 



Much like commit 19f953e7 ("fbdev: fb_pm2fb: Avoid potential divide
by zero error"), we also need to prevent that same crash from happening
in the udlfb driver as it uses pixclock directly when dividing, which
will crash.

Cc: Bernie Thompson <bernie@plugable.com>
Cc: Helge Deller <deller@gmx.de>
Fixes: 59277b67 ("Staging: udlfb: add dynamic modeset support")
Assisted-by: gregkh_clanker_t1000
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 8f98b81f

drivers/video/fbdev/udlfb.c

+3 −0
Original line number Diff line number Diff line
@@ -1018,6 +1018,9 @@ static int dlfb_ops_check_var(struct fb_var_screeninfo *var, 
	struct fb_videomode mode;

	struct dlfb_data *dlfb = info->par;



	if (!var->pixclock)

		return -EINVAL;



	/* set device-specific elements of var unrelated to mode */

	dlfb_var_color_format(var);