Commit a3567281 authored by Steffen Klassert's avatar Steffen Klassert
Browse files

xfrm: Fix acquire state insertion. 



A recent commit jumped over the dst hash computation and
left the symbol uninitialized. Fix this by explicitly
computing the dst hash before it is used.

Fixes: 0045e3d8 ("xfrm: Cache used outbound xfrm states at the policy.")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent 9e1a6db6

net/xfrm/xfrm_state.c

+1 −0
Original line number Diff line number Diff line
@@ -1470,6 +1470,7 @@ xfrm_state_find(const xfrm_address_t *daddr, const xfrm_address_t *saddr, 
			x->km.state = XFRM_STATE_ACQ;

			x->dir = XFRM_SA_DIR_OUT;

			list_add(&x->km.all, &net->xfrm.state_all);

			h = xfrm_dst_hash(net, daddr, saddr, tmpl->reqid, encap_family);

			XFRM_STATE_INSERT(bydst, &x->bydst,

					  net->xfrm.state_bydst + h,

					  x->xso.type);