Commit a4addc33 authored by Marc Kleine-Budde's avatar Marc Kleine-Budde Committed by Jakub Kicinski
Browse files

net: fec: fec_restart(): introduce a define for FEC_ECR_SPEED 



Replace "1 << 5" for configuring 1000 MBit/s with a defined constant to
improve code readability and maintainability.

Reviewed-by: default avatarWei Fang <wei.fang@nxp.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Link: https://patch.msgid.link/20250618-fec-cleanups-v4-6-c16f9a1af124@pengutronix.de


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4e8594a8

drivers/net/ethernet/freescale/fec_main.c

+2 −1
Original line number Diff line number Diff line
@@ -275,6 +275,7 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC address"); 
#define FEC_ECR_MAGICEN         BIT(2)

#define FEC_ECR_SLEEP           BIT(3)

#define FEC_ECR_EN1588          BIT(4)

#define FEC_ECR_SPEED           BIT(5)

#define FEC_ECR_BYTESWP         BIT(8)

/* FEC RCR bits definition */

#define FEC_RCR_LOOP            BIT(0)
@@ -1206,7 +1207,7 @@ fec_restart(struct net_device *ndev) 
		/* 1G, 100M or 10M */

		if (ndev->phydev) {

			if (ndev->phydev->speed == SPEED_1000)

				ecntl |= (1 << 5);

				ecntl |= FEC_ECR_SPEED;

			else if (ndev->phydev->speed == SPEED_100)

				rcntl &= ~FEC_RCR_10BASET;

			else