Commit a58371d6 authored by Srinivasan Shanmugam's avatar Srinivasan Shanmugam Committed by Alex Deucher
Browse files

drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() &... 


drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions

The 'status' variable in 'core_link_read_dpcd()' &
'core_link_write_dpcd()' was uninitialized.

Thus, initializing 'status' variable to 'DC_ERROR_UNEXPECTED' by default.

Fixes the below:
drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:226 core_link_read_dpcd() error: uninitialized symbol 'status'.
drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dpcd.c:248 core_link_write_dpcd() error: uninitialized symbol 'status'.

Cc: stable@vger.kernel.org
Cc: Jerry Zuo <jerry.zuo@amd.com>
Cc: Jun Lei <Jun.Lei@amd.com>
Cc: Wayne Lin <Wayne.Lin@amd.com>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: default avatarSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: default avatarRodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent fdaca31a

drivers/gpu/drm/amd/display/dc/link/protocols/link_dpcd.c

+2 −2
Original line number Diff line number Diff line
@@ -205,7 +205,7 @@ enum dc_status core_link_read_dpcd( 
	uint32_t extended_size;

	/* size of the remaining partitioned address space */

	uint32_t size_left_to_read;

	enum dc_status status;

	enum dc_status status = DC_ERROR_UNEXPECTED;

	/* size of the next partition to be read from */

	uint32_t partition_size;

	uint32_t data_index = 0;
@@ -234,7 +234,7 @@ enum dc_status core_link_write_dpcd( 
{

	uint32_t partition_size;

	uint32_t data_index = 0;

	enum dc_status status;

	enum dc_status status = DC_ERROR_UNEXPECTED;



	while (size) {

		partition_size = dpcd_get_next_partition_size(address, size);