Commit a5c79735 authored by Alexey Charkov's avatar Alexey Charkov Committed by Greg Kroah-Hartman
Browse files

usb: uhci-platform: Make the clock really optional 



Device tree bindings state that the clock is optional for UHCI platform
controllers, and some existing device trees don't provide those - such
as those for VIA/WonderMedia devices.

The driver however fails to probe now if no clock is provided, because
devm_clk_get returns an error pointer in such case.

Switch to devm_clk_get_optional instead, so that it could probe again
on those platforms where no clocks are given.

Cc: stable <stable@kernel.org>
Fixes: 26c50270 ("usb: uhci: Add clk support to uhci-platform")
Signed-off-by: default avatarAlexey Charkov <alchark@gmail.com>
Link: https://lore.kernel.org/r/20250425-uhci-clock-optional-v1-1-a1d462592f29@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2372f1ca

drivers/usb/host/uhci-platform.c

+1 −1
Original line number Diff line number Diff line
@@ -121,7 +121,7 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) 
	}



	/* Get and enable clock if any specified */

	uhci->clk = devm_clk_get(&pdev->dev, NULL);

	uhci->clk = devm_clk_get_optional(&pdev->dev, NULL);

	if (IS_ERR(uhci->clk)) {

		ret = PTR_ERR(uhci->clk);

		goto err_rmr;