Commit a63db07e authored by Somnath Kotur's avatar Somnath Kotur Committed by David S. Miller
Browse files

bnxt_en: Add missing skb_mark_for_recycle() in bnxt_rx_vlan() 



If bnxt_rx_vlan() fails because the VLAN protocol ID is invalid,
the SKB is freed but we're missing the call to recycle it.  This
may cause the warning:

"page_pool_release_retry() stalled pool shutdown"

Add the missing skb_mark_for_recycle() in bnxt_rx_vlan().

Fixes: 86b05508 ("bnxt_en: Use the unified RX page pool buffers for XDP and non-XDP")
Reviewed-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: default avatarSomnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8e6cc904

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+1 −0
Original line number Diff line number Diff line
@@ -2015,6 +2015,7 @@ static struct sk_buff *bnxt_rx_vlan(struct sk_buff *skb, u8 cmp_type, 
	}

	return skb;

vlan_err:

	skb_mark_for_recycle(skb);

	dev_kfree_skb(skb);

	return NULL;

}