Commit a67fd55f authored by Pablo Neira Ayuso's avatar Pablo Neira Ayuso Committed by Florian Westphal
Browse files

netfilter: nf_tables: remove redundant chain validation on register store 



This validation predates the introduction of the state machine that
determines when to enter slow path validation for error reporting.

Currently, table validation is perform when:

- new rule contains expressions that need validation.
- new set element with jump/goto verdict.

Validation on register store skips most checks with no basechains, still
this walks the graph searching for loops and ensuring expressions are
called from the right hook. Remove this.

Fixes: a654de8f ("netfilter: nf_tables: fix chain dependency validation")
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
parent 5ec8ca26

net/netfilter/nf_tables_api.c

+0 −11
Original line number Diff line number Diff line
@@ -11676,21 +11676,10 @@ static int nft_validate_register_store(const struct nft_ctx *ctx, 
				       enum nft_data_types type,

				       unsigned int len)

{

	int err;



	switch (reg) {

	case NFT_REG_VERDICT:

		if (type != NFT_DATA_VERDICT)

			return -EINVAL;



		if (data != NULL &&

		    (data->verdict.code == NFT_GOTO ||

		     data->verdict.code == NFT_JUMP)) {

			err = nft_chain_validate(ctx, data->verdict.chain);

			if (err < 0)

				return err;

		}



		break;

	default:

		if (type != NFT_DATA_VALUE)