Commit a73ddcba authored by Luca Ceresoli's avatar Luca Ceresoli
Browse files

drm/mxsfb: put the bridge returned by drm_bridge_chain_get_first_bridge() 



The bridge returned by drm_bridge_chain_get_first_bridge() is
refcounted. Put it when done. Use a scope-based free action to catch all
the code paths.

Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/r/20250708-drm-bridge-alloc-getput-drm_bridge_chain_get_first_bridge-v9-3-db1ba3df7f58@bootlin.com


Signed-off-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
parent 8fa59094

drivers/gpu/drm/mxsfb/lcdif_kms.c

+2 −2
Original line number Diff line number Diff line
@@ -433,7 +433,6 @@ static int lcdif_crtc_atomic_check(struct drm_crtc *crtc, 
	struct drm_connector *connector;

	struct drm_encoder *encoder;

	struct drm_bridge_state *bridge_state;

	struct drm_bridge *bridge;

	u32 bus_format, bus_flags;

	bool format_set = false, flags_set = false;

	int ret, i;
@@ -453,7 +452,8 @@ static int lcdif_crtc_atomic_check(struct drm_crtc *crtc, 


		encoder = connector_state->best_encoder;



		bridge = drm_bridge_chain_get_first_bridge(encoder);

		struct drm_bridge *bridge __free(drm_bridge_put) =

			drm_bridge_chain_get_first_bridge(encoder);

		if (!bridge)

			continue;