Unverified Commit a779e27f authored by Christian Brauner's avatar Christian Brauner
Browse files

coredump: fix core_pattern input validation 



In be1e0283 ("coredump: don't pointlessly check and spew warnings")
we tried to fix input validation so it only happens during a write to
core_pattern. This would avoid needlessly logging a lot of warnings
during a read operation. However the logic accidently got inverted in
this commit. Fix it so the input validation only happens on write and is
skipped on read.

Fixes: be1e0283 ("coredump: don't pointlessly check and spew warnings")
Fixes: 16195d2c ("coredump: validate socket name as it is written")
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reported-by: default avatarYu Watanabe <watanabe.yu@gmail.com>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 56094ad3

fs/coredump.c

+1 −1
Original line number Diff line number Diff line
@@ -1468,7 +1468,7 @@ static int proc_dostring_coredump(const struct ctl_table *table, int write, 
	ssize_t retval;

	char old_core_pattern[CORENAME_MAX_SIZE];



	if (write)

	if (!write)

		return proc_dostring(table, write, buffer, lenp, ppos);



	retval = strscpy(old_core_pattern, core_pattern, CORENAME_MAX_SIZE);

fs/exec.c

+1 −1
Original line number Diff line number Diff line
@@ -2048,7 +2048,7 @@ static int proc_dointvec_minmax_coredump(const struct ctl_table *table, int writ 
{

	int error = proc_dointvec_minmax(table, write, buffer, lenp, ppos);



	if (!error && !write)

	if (!error && write)

		validate_coredump_safety();

	return error;

}