Commit a7f87dea authored by Aradhya Bhatia's avatar Aradhya Bhatia Committed by Matt Roper
Browse files

drm/xe: Default auto_link_downgrade status to false 



xe_pcode_read() can return back successfully without updating the
variable 'val'. This can cause an arbitrary value to show up in the
sysfs file.

Allow the auto_link_downgrade_status to default to 0 to avoid any
arbitrary value from coming up.

Fixes: 0e414bf7 ("drm/xe: Expose PCIe link downgrade attributes")
Reviewed-by: default avatarTejas Upadhyay <tejas.upadhyay@intel.com>
Signed-off-by: default avatarAradhya Bhatia <aradhya.bhatia@intel.com>
Link: https://lore.kernel.org/r/20250516124355.4872-1-aradhya.bhatia@intel.com


Signed-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
parent 17486cf3

drivers/gpu/drm/xe/xe_device_sysfs.c

+2 −1
Original line number Diff line number Diff line
@@ -124,7 +124,8 @@ auto_link_downgrade_status_show(struct device *dev, struct device_attribute *att 
{

	struct pci_dev *pdev = to_pci_dev(dev);

	struct xe_device *xe = pdev_to_xe_device(pdev);

	u32 val;

	/* default the auto_link_downgrade status to 0 */

	u32 val = 0;

	int ret;



	xe_pm_runtime_get(xe);