Commit a8d8bef6 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

ethtool: strset: fix header attribute index in ethnl_req_get_phydev() 



strset_prepare_data() passes ETHTOOL_A_HEADER_FLAGS (3) as the header
attribute to ethnl_req_get_phydev(). This is incorrect, in the main
attr space 3 is ETHTOOL_A_STRSET_COUNTS_ONLY, not the request
header attr. The correct constant is ETHTOOL_A_STRSET_HEADER (1).

ethnl_req_get_phydev() only uses this value for the extack,
so this is not a "functionally visible"(?) bug.

Fixes: e96c93aa ("net: ethtool: strset: Allow querying phy stats by index")
Reviewed-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20260526153533.2779187-9-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c3fc9976

net/ethtool/strset.c

+1 −1
Original line number Diff line number Diff line
@@ -311,7 +311,7 @@ static int strset_prepare_data(const struct ethnl_req_info *req_base, 
		return 0;

	}



	phydev = ethnl_req_get_phydev(req_base, tb, ETHTOOL_A_HEADER_FLAGS,

	phydev = ethnl_req_get_phydev(req_base, tb, ETHTOOL_A_STRSET_HEADER,

				      info->extack);



	/* phydev can be NULL, check for errors only */