Commit a93c3ad6 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: st: simplify with dev_err_probe 



Use dev_err_probe() to make the error paths a bit simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarPatrice Chotard <patrice.chotard@foss.st.com>
Acked-by: default avatarThinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20240814-b4-cleanup-h-of-node-put-usb-v1-2-95481b9682bc@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bde05325

drivers/usb/dwc3/dwc3-st.c

+5 −6
Original line number Diff line number Diff line
@@ -237,10 +237,9 @@ static int st_dwc3_probe(struct platform_device *pdev) 


	dwc3_data->rstc_pwrdn =

		devm_reset_control_get_exclusive(dev, "powerdown");

	if (IS_ERR(dwc3_data->rstc_pwrdn)) {

		dev_err(&pdev->dev, "could not get power controller\n");

		return PTR_ERR(dwc3_data->rstc_pwrdn);

	}

	if (IS_ERR(dwc3_data->rstc_pwrdn))

		return dev_err_probe(dev, PTR_ERR(dwc3_data->rstc_pwrdn),

				     "could not get power controller\n");



	/* Manage PowerDown */

	reset_control_deassert(dwc3_data->rstc_pwrdn);
@@ -248,8 +247,8 @@ static int st_dwc3_probe(struct platform_device *pdev) 
	dwc3_data->rstc_rst =

		devm_reset_control_get_shared(dev, "softreset");

	if (IS_ERR(dwc3_data->rstc_rst)) {

		dev_err(&pdev->dev, "could not get reset controller\n");

		ret = PTR_ERR(dwc3_data->rstc_rst);

		ret = dev_err_probe(dev, PTR_ERR(dwc3_data->rstc_rst),

				    "could not get reset controller\n");

		goto undo_powerdown;

	}