Commit a9b1fab3 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

Merge branch 'ionic-convert-rx-queue-buffers-to-use-page_pool' 

Brett Creeley says:

====================
ionic: convert Rx queue buffers to use page_pool

Our home-grown buffer management needs to go away and we need to play
nicely with the page_pool infrastructure.  This patchset cleans up some
of our API use and converts the Rx traffic queues to use page_pool.
The first few patches are for tidying up things, then a small XDP
configuration refactor, adding page_pool support, and finally adding
support to hot swap an XDP program without having to reconfigure
anything.

The result is code that more closely follows current patterns, as well as
a either a performance boost or equivalent performance as seen with
iperf testing:

  mss   netio    tx_pps      rx_pps      total_pps      tx_bw    rx_bw    total_bw
  ----  -------  ----------  ----------  -----------  -------  -------  ----------
Before:
  256   bidir    13,839,293  15,515,227  29,354,520        34       38          71
  512   bidir    13,913,249  14,671,693  28,584,942        62       65         127
  1024  bidir    13,006,189  13,695,413  26,701,602       109      115         224
  1448  bidir    12,489,905  12,791,734  25,281,639       145      149         294
  2048  bidir    9,195,622   9,247,649   18,443,271       148      149         297
  4096  bidir    5,149,716   5,247,917   10,397,633       160      163         323
  8192  bidir    3,029,993   3,008,882   6,038,875        179      179         358
  9000  bidir    2,789,358   2,800,744   5,590,102        181      180         361

After:
  256   bidir    21,540,037  21,344,644  42,884,681        52       52         104
  512   bidir    23,170,014  19,207,260  42,377,274       103       85         188
  1024  bidir    17,934,280  17,819,247  35,753,527       150      149         299
  1448  bidir    15,242,515  14,907,030  30,149,545       167      174         341
  2048  bidir    10,692,542  10,663,023  21,355,565       177      176         353
  4096  bidir    6,024,977   6,083,580   12,108,557       187      180         367
  8192  bidir    3,090,449   3,048,266   6,138,715        180      176         356
  9000  bidir    2,859,146   2,864,226   5,723,372        178      180         358

v2: https://lore.kernel.org/20240826184422.21895-1-brett.creeley@amd.com
v1: https://lore.kernel.org/20240625165658.34598-1-shannon.nelson@amd.com
====================

Link: https://patch.msgid.link/20240906232623.39651-1-brett.creeley@amd.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parents 760664b7 3c0bf13f

drivers/net/ethernet/pensando/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ config IONIC 
	depends on PTP_1588_CLOCK_OPTIONAL

	select NET_DEVLINK

	select DIMLIB

	select PAGE_POOL

	help

	  This enables the support for the Pensando family of Ethernet

	  adapters.  More specific information on this driver can be

drivers/net/ethernet/pensando/ionic/ionic_dev.h

+12 −11
Original line number Diff line number Diff line
@@ -181,10 +181,7 @@ struct ionic_queue; 
struct ionic_qcq;



#define IONIC_MAX_BUF_LEN			((u16)-1)

#define IONIC_PAGE_SIZE				PAGE_SIZE

#define IONIC_PAGE_SPLIT_SZ			(PAGE_SIZE / 2)

#define IONIC_PAGE_GFP_MASK			(GFP_ATOMIC | __GFP_NOWARN |\

						 __GFP_COMP | __GFP_MEMALLOC)

#define IONIC_PAGE_SIZE				MIN(PAGE_SIZE, IONIC_MAX_BUF_LEN)



#define IONIC_XDP_MAX_LINEAR_MTU	(IONIC_PAGE_SIZE -	\

					 (VLAN_ETH_HLEN +	\
@@ -238,9 +235,8 @@ struct ionic_queue { 
	unsigned int index;

	unsigned int num_descs;

	unsigned int max_sg_elems;



	u64 features;

	unsigned int type;

	unsigned int hw_index;

	unsigned int hw_type;

	bool xdp_flush;

	union {
@@ -249,11 +245,6 @@ struct ionic_queue { 
		struct ionic_rxq_desc *rxq;

		struct ionic_admin_cmd *adminq;

	};

	union {

		void __iomem *cmb_base;

		struct ionic_txq_desc __iomem *cmb_txq;

		struct ionic_rxq_desc __iomem *cmb_rxq;

	};

	union {

		void *sg_base;

		struct ionic_txq_sg_desc *txq_sgl;
@@ -261,7 +252,17 @@ struct ionic_queue { 
		struct ionic_rxq_sg_desc *rxq_sgl;

	};

	struct xdp_rxq_info *xdp_rxq_info;

	struct bpf_prog *xdp_prog;

	struct page_pool *page_pool;

	struct ionic_queue *partner;



	union {

		void __iomem *cmb_base;

		struct ionic_txq_desc __iomem *cmb_txq;

		struct ionic_rxq_desc __iomem *cmb_rxq;

	};

	unsigned int type;

	unsigned int hw_index;

	dma_addr_t base_pa;

	dma_addr_t cmb_base_pa;

	dma_addr_t sg_base_pa;

drivers/net/ethernet/pensando/ionic/ionic_lif.c

+95 −64
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ 
#include <linux/cpumask.h>

#include <linux/crash_dump.h>

#include <linux/vmalloc.h>

#include <net/page_pool/helpers.h>



#include "ionic.h"

#include "ionic_bus.h"
@@ -46,8 +47,9 @@ static int ionic_start_queues(struct ionic_lif *lif); 
static void ionic_stop_queues(struct ionic_lif *lif);

static void ionic_lif_queue_identify(struct ionic_lif *lif);



static int ionic_xdp_queues_config(struct ionic_lif *lif);

static void ionic_xdp_unregister_rxq_info(struct ionic_queue *q);

static void ionic_xdp_rxqs_prog_update(struct ionic_lif *lif);

static void ionic_unregister_rxq_info(struct ionic_queue *q);

static int ionic_register_rxq_info(struct ionic_queue *q, unsigned int napi_id);



static void ionic_dim_work(struct work_struct *work)

{
@@ -380,6 +382,7 @@ static void ionic_lif_qcq_deinit(struct ionic_lif *lif, struct ionic_qcq *qcq) 
	if (!(qcq->flags & IONIC_QCQ_F_INITED))

		return;



	ionic_unregister_rxq_info(&qcq->q);

	if (qcq->flags & IONIC_QCQ_F_INTR) {

		ionic_intr_mask(idev->intr_ctrl, qcq->intr.index,

				IONIC_INTR_MASK_SET);
@@ -437,9 +440,10 @@ static void ionic_qcq_free(struct ionic_lif *lif, struct ionic_qcq *qcq) 
		qcq->sg_base_pa = 0;

	}



	ionic_xdp_unregister_rxq_info(&qcq->q);

	ionic_qcq_intr_free(lif, qcq);

	page_pool_destroy(qcq->q.page_pool);

	qcq->q.page_pool = NULL;



	ionic_qcq_intr_free(lif, qcq);

	vfree(qcq->q.info);

	qcq->q.info = NULL;

}
@@ -553,7 +557,8 @@ static int ionic_qcq_alloc(struct ionic_lif *lif, unsigned int type, 
			   unsigned int cq_desc_size,

			   unsigned int sg_desc_size,

			   unsigned int desc_info_size,

			   unsigned int pid, struct ionic_qcq **qcq)

			   unsigned int pid, struct bpf_prog *xdp_prog,

			   struct ionic_qcq **qcq)

{

	struct ionic_dev *idev = &lif->ionic->idev;

	struct device *dev = lif->ionic->dev;
@@ -579,6 +584,31 @@ static int ionic_qcq_alloc(struct ionic_lif *lif, unsigned int type, 
		goto err_out_free_qcq;

	}



	if (type == IONIC_QTYPE_RXQ) {

		struct page_pool_params pp_params = {

			.flags = PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV,

			.order = 0,

			.pool_size = num_descs,

			.nid = NUMA_NO_NODE,

			.dev = lif->ionic->dev,

			.napi = &new->napi,

			.dma_dir = DMA_FROM_DEVICE,

			.max_len = PAGE_SIZE,

			.netdev = lif->netdev,

		};



		if (xdp_prog)

			pp_params.dma_dir = DMA_BIDIRECTIONAL;



		new->q.page_pool = page_pool_create(&pp_params);

		if (IS_ERR(new->q.page_pool)) {

			netdev_err(lif->netdev, "Cannot create page_pool\n");

			err = PTR_ERR(new->q.page_pool);

			new->q.page_pool = NULL;

			goto err_out_free_q_info;

		}

	}



	new->q.type = type;

	new->q.max_sg_elems = lif->qtype_info[type].max_sg_elems;
@@ -586,12 +616,12 @@ static int ionic_qcq_alloc(struct ionic_lif *lif, unsigned int type, 
			   desc_size, sg_desc_size, pid);

	if (err) {

		netdev_err(lif->netdev, "Cannot initialize queue\n");

		goto err_out_free_q_info;

		goto err_out_free_page_pool;

	}



	err = ionic_alloc_qcq_interrupt(lif, new);

	if (err)

		goto err_out_free_q_info;

		goto err_out_free_page_pool;



	err = ionic_cq_init(lif, &new->cq, &new->intr, num_descs, cq_desc_size);

	if (err) {
@@ -712,6 +742,8 @@ static int ionic_qcq_alloc(struct ionic_lif *lif, unsigned int type, 
		devm_free_irq(dev, new->intr.vector, &new->napi);

		ionic_intr_free(lif->ionic, new->intr.index);

	}

err_out_free_page_pool:

	page_pool_destroy(new->q.page_pool);

err_out_free_q_info:

	vfree(new->q.info);

err_out_free_qcq:
@@ -734,7 +766,7 @@ static int ionic_qcqs_alloc(struct ionic_lif *lif) 
			      sizeof(struct ionic_admin_comp),

			      0,

			      sizeof(struct ionic_admin_desc_info),

			      lif->kern_pid, &lif->adminqcq);

			      lif->kern_pid, NULL, &lif->adminqcq);

	if (err)

		return err;

	ionic_debugfs_add_qcq(lif, lif->adminqcq);
@@ -747,7 +779,7 @@ static int ionic_qcqs_alloc(struct ionic_lif *lif) 
				      sizeof(union ionic_notifyq_comp),

				      0,

				      sizeof(struct ionic_admin_desc_info),

				      lif->kern_pid, &lif->notifyqcq);

				      lif->kern_pid, NULL, &lif->notifyqcq);

		if (err)

			goto err_out;

		ionic_debugfs_add_qcq(lif, lif->notifyqcq);
@@ -925,6 +957,11 @@ static int ionic_lif_rxq_init(struct ionic_lif *lif, struct ionic_qcq *qcq) 
		netif_napi_add(lif->netdev, &qcq->napi, ionic_rx_napi);

	else

		netif_napi_add(lif->netdev, &qcq->napi, ionic_txrx_napi);

	err = ionic_register_rxq_info(q, qcq->napi.napi_id);

	if (err) {

		netif_napi_del(&qcq->napi);

		return err;

	}



	qcq->flags |= IONIC_QCQ_F_INITED;
@@ -960,7 +997,7 @@ int ionic_lif_create_hwstamp_txq(struct ionic_lif *lif) 
	err = ionic_qcq_alloc(lif, IONIC_QTYPE_TXQ, txq_i, "hwstamp_tx", flags,

			      num_desc, desc_sz, comp_sz, sg_desc_sz,

			      sizeof(struct ionic_tx_desc_info),

			      lif->kern_pid, &txq);

			      lif->kern_pid, NULL, &txq);

	if (err)

		goto err_qcq_alloc;
@@ -1020,7 +1057,7 @@ int ionic_lif_create_hwstamp_rxq(struct ionic_lif *lif) 
	err = ionic_qcq_alloc(lif, IONIC_QTYPE_RXQ, rxq_i, "hwstamp_rx", flags,

			      num_desc, desc_sz, comp_sz, sg_desc_sz,

			      sizeof(struct ionic_rx_desc_info),

			      lif->kern_pid, &rxq);

			      lif->kern_pid, NULL, &rxq);

	if (err)

		goto err_qcq_alloc;
@@ -1037,7 +1074,7 @@ int ionic_lif_create_hwstamp_rxq(struct ionic_lif *lif) 
			goto err_qcq_init;



		if (test_bit(IONIC_LIF_F_UP, lif->state)) {

			ionic_rx_fill(&rxq->q);

			ionic_rx_fill(&rxq->q, NULL);

			err = ionic_qcq_enable(rxq);

			if (err)

				goto err_qcq_enable;
@@ -2046,7 +2083,7 @@ static int ionic_txrx_alloc(struct ionic_lif *lif) 
		err = ionic_qcq_alloc(lif, IONIC_QTYPE_TXQ, i, "tx", flags,

				      num_desc, desc_sz, comp_sz, sg_desc_sz,

				      sizeof(struct ionic_tx_desc_info),

				      lif->kern_pid, &lif->txqcqs[i]);

				      lif->kern_pid, NULL, &lif->txqcqs[i]);

		if (err)

			goto err_out;
@@ -2078,7 +2115,8 @@ static int ionic_txrx_alloc(struct ionic_lif *lif) 
		err = ionic_qcq_alloc(lif, IONIC_QTYPE_RXQ, i, "rx", flags,

				      num_desc, desc_sz, comp_sz, sg_desc_sz,

				      sizeof(struct ionic_rx_desc_info),

				      lif->kern_pid, &lif->rxqcqs[i]);

				      lif->kern_pid, lif->xdp_prog,

				      &lif->rxqcqs[i]);

		if (err)

			goto err_out;
@@ -2143,9 +2181,7 @@ static int ionic_txrx_enable(struct ionic_lif *lif) 
	int derr = 0;

	int i, err;



	err = ionic_xdp_queues_config(lif);

	if (err)

		return err;

	ionic_xdp_rxqs_prog_update(lif);



	for (i = 0; i < lif->nxqs; i++) {

		if (!(lif->rxqcqs[i] && lif->txqcqs[i])) {
@@ -2154,7 +2190,8 @@ static int ionic_txrx_enable(struct ionic_lif *lif) 
			goto err_out;

		}



		ionic_rx_fill(&lif->rxqcqs[i]->q);

		ionic_rx_fill(&lif->rxqcqs[i]->q,

			      READ_ONCE(lif->rxqcqs[i]->q.xdp_prog));

		err = ionic_qcq_enable(lif->rxqcqs[i]);

		if (err)

			goto err_out;
@@ -2167,7 +2204,7 @@ static int ionic_txrx_enable(struct ionic_lif *lif) 
	}



	if (lif->hwstamp_rxq) {

		ionic_rx_fill(&lif->hwstamp_rxq->q);

		ionic_rx_fill(&lif->hwstamp_rxq->q, NULL);

		err = ionic_qcq_enable(lif->hwstamp_rxq);

		if (err)

			goto err_out_hwstamp_rx;
@@ -2192,7 +2229,7 @@ static int ionic_txrx_enable(struct ionic_lif *lif) 
		derr = ionic_qcq_disable(lif, lif->rxqcqs[i], derr);

	}



	ionic_xdp_queues_config(lif);

	ionic_xdp_rxqs_prog_update(lif);



	return err;

}
@@ -2651,7 +2688,7 @@ static void ionic_vf_attr_replay(struct ionic_lif *lif) 
	ionic_vf_start(ionic);

}



static void ionic_xdp_unregister_rxq_info(struct ionic_queue *q)

static void ionic_unregister_rxq_info(struct ionic_queue *q)

{

	struct xdp_rxq_info *xi;
@@ -2665,7 +2702,7 @@ static void ionic_xdp_unregister_rxq_info(struct ionic_queue *q) 
	kfree(xi);

}



static int ionic_xdp_register_rxq_info(struct ionic_queue *q, unsigned int napi_id)

static int ionic_register_rxq_info(struct ionic_queue *q, unsigned int napi_id)

{

	struct xdp_rxq_info *rxq_info;

	int err;
@@ -2676,14 +2713,14 @@ static int ionic_xdp_register_rxq_info(struct ionic_queue *q, unsigned int napi_ 


	err = xdp_rxq_info_reg(rxq_info, q->lif->netdev, q->index, napi_id);

	if (err) {

		dev_err(q->dev, "Queue %d xdp_rxq_info_reg failed, err %d\n",

		netdev_err(q->lif->netdev, "q%d xdp_rxq_info_reg failed, err %d\n",

			   q->index, err);

		goto err_out;

	}



	err = xdp_rxq_info_reg_mem_model(rxq_info, MEM_TYPE_PAGE_ORDER0, NULL);

	err = xdp_rxq_info_reg_mem_model(rxq_info, MEM_TYPE_PAGE_POOL, q->page_pool);

	if (err) {

		dev_err(q->dev, "Queue %d xdp_rxq_info_reg_mem_model failed, err %d\n",

		netdev_err(q->lif->netdev, "q%d xdp_rxq_info_reg_mem_model failed, err %d\n",

			   q->index, err);

		xdp_rxq_info_unreg(rxq_info);

		goto err_out;
@@ -2698,44 +2735,20 @@ static int ionic_xdp_register_rxq_info(struct ionic_queue *q, unsigned int napi_ 
	return err;

}



static int ionic_xdp_queues_config(struct ionic_lif *lif)

static void ionic_xdp_rxqs_prog_update(struct ionic_lif *lif)

{

	struct bpf_prog *xdp_prog;

	unsigned int i;

	int err;



	if (!lif->rxqcqs)

		return 0;



	/* There's no need to rework memory if not going to/from NULL program.

	 * If there is no lif->xdp_prog, there should also be no q.xdp_rxq_info

	 * This way we don't need to keep an *xdp_prog in every queue struct.

	 */

	if (!lif->xdp_prog == !lif->rxqcqs[0]->q.xdp_rxq_info)

		return 0;

		return;



	xdp_prog = READ_ONCE(lif->xdp_prog);

	for (i = 0; i < lif->ionic->nrxqs_per_lif && lif->rxqcqs[i]; i++) {

		struct ionic_queue *q = &lif->rxqcqs[i]->q;



		if (q->xdp_rxq_info) {

			ionic_xdp_unregister_rxq_info(q);

			continue;

		WRITE_ONCE(q->xdp_prog, xdp_prog);

	}



		err = ionic_xdp_register_rxq_info(q, lif->rxqcqs[i]->napi.napi_id);

		if (err) {

			dev_err(lif->ionic->dev, "failed to register RX queue %d info for XDP, err %d\n",

				i, err);

			goto err_out;

		}

	}



	return 0;



err_out:

	for (i = 0; i < lif->ionic->nrxqs_per_lif && lif->rxqcqs[i]; i++)

		ionic_xdp_unregister_rxq_info(&lif->rxqcqs[i]->q);



	return err;

}



static int ionic_xdp_config(struct net_device *netdev, struct netdev_bpf *bpf)
@@ -2765,11 +2778,17 @@ static int ionic_xdp_config(struct net_device *netdev, struct netdev_bpf *bpf) 


	if (!netif_running(netdev)) {

		old_prog = xchg(&lif->xdp_prog, bpf->prog);

	} else if (lif->xdp_prog && bpf->prog) {

		old_prog = xchg(&lif->xdp_prog, bpf->prog);

		ionic_xdp_rxqs_prog_update(lif);

	} else {

		struct ionic_queue_params qparams;



		ionic_init_queue_params(lif, &qparams);

		qparams.xdp_prog = bpf->prog;

		mutex_lock(&lif->queue_lock);

		ionic_stop_queues_reconfig(lif);

		ionic_reconfigure_queues(lif, &qparams);

		old_prog = xchg(&lif->xdp_prog, bpf->prog);

		ionic_start_queues_reconfig(lif);

		mutex_unlock(&lif->queue_lock);

	}
@@ -2871,13 +2890,23 @@ static int ionic_cmb_reconfig(struct ionic_lif *lif, 


static void ionic_swap_queues(struct ionic_qcq *a, struct ionic_qcq *b)

{

	/* only swapping the queues, not the napi, flags, or other stuff */

	/* only swapping the queues and napi, not flags or other stuff */

	swap(a->napi,         b->napi);



	if (a->q.type == IONIC_QTYPE_RXQ) {

		swap(a->q.page_pool, b->q.page_pool);

		a->q.page_pool->p.napi = &a->napi;

		if (b->q.page_pool)  /* is NULL when increasing queue count */

			b->q.page_pool->p.napi = &b->napi;

	}



	swap(a->q.features,   b->q.features);

	swap(a->q.num_descs,  b->q.num_descs);

	swap(a->q.desc_size,  b->q.desc_size);

	swap(a->q.base,       b->q.base);

	swap(a->q.base_pa,    b->q.base_pa);

	swap(a->q.info,       b->q.info);

	swap(a->q.xdp_prog,   b->q.xdp_prog);

	swap(a->q.xdp_rxq_info, b->q.xdp_rxq_info);

	swap(a->q.partner,    b->q.partner);

	swap(a->q_base,       b->q_base);
@@ -2928,7 +2957,8 @@ int ionic_reconfigure_queues(struct ionic_lif *lif, 
	}

	if (qparam->nxqs != lif->nxqs ||

	    qparam->nrxq_descs != lif->nrxq_descs ||

	    qparam->rxq_features != lif->rxq_features) {

	    qparam->rxq_features != lif->rxq_features ||

	    qparam->xdp_prog != lif->xdp_prog) {

		rx_qcqs = devm_kcalloc(lif->ionic->dev, lif->ionic->nrxqs_per_lif,

				       sizeof(struct ionic_qcq *), GFP_KERNEL);

		if (!rx_qcqs) {
@@ -2959,7 +2989,7 @@ int ionic_reconfigure_queues(struct ionic_lif *lif, 
				err = ionic_qcq_alloc(lif, IONIC_QTYPE_TXQ, i, "tx", flags,

						      4, desc_sz, comp_sz, sg_desc_sz,

						      sizeof(struct ionic_tx_desc_info),

						      lif->kern_pid, &lif->txqcqs[i]);

						      lif->kern_pid, NULL, &lif->txqcqs[i]);

				if (err)

					goto err_out;

			}
@@ -2968,7 +2998,7 @@ int ionic_reconfigure_queues(struct ionic_lif *lif, 
			err = ionic_qcq_alloc(lif, IONIC_QTYPE_TXQ, i, "tx", flags,

					      num_desc, desc_sz, comp_sz, sg_desc_sz,

					      sizeof(struct ionic_tx_desc_info),

					      lif->kern_pid, &tx_qcqs[i]);

					      lif->kern_pid, NULL, &tx_qcqs[i]);

			if (err)

				goto err_out;

		}
@@ -2990,7 +3020,7 @@ int ionic_reconfigure_queues(struct ionic_lif *lif, 
				err = ionic_qcq_alloc(lif, IONIC_QTYPE_RXQ, i, "rx", flags,

						      4, desc_sz, comp_sz, sg_desc_sz,

						      sizeof(struct ionic_rx_desc_info),

						      lif->kern_pid, &lif->rxqcqs[i]);

						      lif->kern_pid, NULL, &lif->rxqcqs[i]);

				if (err)

					goto err_out;

			}
@@ -2999,11 +3029,12 @@ int ionic_reconfigure_queues(struct ionic_lif *lif, 
			err = ionic_qcq_alloc(lif, IONIC_QTYPE_RXQ, i, "rx", flags,

					      num_desc, desc_sz, comp_sz, sg_desc_sz,

					      sizeof(struct ionic_rx_desc_info),

					      lif->kern_pid, &rx_qcqs[i]);

					      lif->kern_pid, qparam->xdp_prog, &rx_qcqs[i]);

			if (err)

				goto err_out;



			rx_qcqs[i]->q.features = qparam->rxq_features;

			rx_qcqs[i]->q.xdp_prog = qparam->xdp_prog;

		}

	}

drivers/net/ethernet/pensando/ionic/ionic_lif.h

+2 −0
Original line number Diff line number Diff line
@@ -268,6 +268,7 @@ struct ionic_queue_params { 
	unsigned int ntxq_descs;

	unsigned int nrxq_descs;

	u64 rxq_features;

	struct bpf_prog *xdp_prog;

	bool intr_split;

	bool cmb_tx;

	bool cmb_rx;
@@ -280,6 +281,7 @@ static inline void ionic_init_queue_params(struct ionic_lif *lif, 
	qparam->ntxq_descs = lif->ntxq_descs;

	qparam->nrxq_descs = lif->nrxq_descs;

	qparam->rxq_features = lif->rxq_features;

	qparam->xdp_prog = lif->xdp_prog;

	qparam->intr_split = test_bit(IONIC_LIF_F_SPLIT_INTR, lif->state);

	qparam->cmb_tx = test_bit(IONIC_LIF_F_CMB_TX_RINGS, lif->state);

	qparam->cmb_rx = test_bit(IONIC_LIF_F_CMB_RX_RINGS, lif->state);

drivers/net/ethernet/pensando/ionic/ionic_txrx.c

+217 −203

File changed.

Preview size limit exceeded, changes collapsed.