Commit aa6f4f94 authored by Shuai Xue's avatar Shuai Xue Committed by Vinod Koul
Browse files

dmaengine: idxd: fix memory leak in error handling path of idxd_setup_groups 



Memory allocated for groups is not freed if an error occurs during
idxd_setup_groups(). To fix it, free the allocated memory in the reverse
order of allocation before exiting the function in case of an error.

Fixes: defe49f9 ("dmaengine: idxd: fix group conf_dev lifetime")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarShuai Xue <xueshuai@linux.alibaba.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarFenghua Yu <fenghuay@nvidia.com>
Link: https://lore.kernel.org/r/20250404120217.48772-4-xueshuai@linux.alibaba.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 817bced1

drivers/dma/idxd/init.c

+4 −0
Original line number Diff line number Diff line
@@ -326,6 +326,7 @@ static int idxd_setup_groups(struct idxd_device *idxd) 
		rc = dev_set_name(conf_dev, "group%d.%d", idxd->id, group->id);

		if (rc < 0) {

			put_device(conf_dev);

			kfree(group);

			goto err;

		}
@@ -350,7 +351,10 @@ static int idxd_setup_groups(struct idxd_device *idxd) 
	while (--i >= 0) {

		group = idxd->groups[i];

		put_device(group_confdev(group));

		kfree(group);

	}

	kfree(idxd->groups);



	return rc;

}