Commit aac2f836 authored by Joe Hattori's avatar Joe Hattori Committed by Vinod Koul
Browse files

soundwire: slave: fix an OF node reference leak in soundwire slave device 



When initializing a soundwire slave device, an OF node is stored to the
device with refcount incremented. However, the refcount is not
decremented in .release(), thus call of_node_put() in
sdw_slave_release().

Fixes: a2e48458 ("soundwire: core: add device tree support for slave devices")
Signed-off-by: default avatarJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20241205034844.2784964-1-joe@pf.is.s.u-tokyo.ac.jp


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 836c8a2e

drivers/soundwire/slave.c

+1 −0
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ static void sdw_slave_release(struct device *dev) 
{

	struct sdw_slave *slave = dev_to_sdw_dev(dev);



	of_node_put(slave->dev.of_node);

	mutex_destroy(&slave->sdw_dev_lock);

	kfree(slave);

}