Commit aac5ba6a authored by Aaron Kling's avatar Aaron Kling Committed by Bjorn Helgaas
Browse files

PCI: tegra: Allow building as a module 



Change the module macro back to builtin, which does not define an exit
function. This will prevent the module from being unloaded. There are
concerns with modules not cleaning up IRQs on unload, thus unload must be
specifically disallowed. Drop the remove callback as it is unused.

Signed-off-by: default avatarAaron Kling <webgeek1234@gmail.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20250731-pci-tegra-module-v7-3-cad4b088b8fb@gmail.com
parent eefff3d9

drivers/pci/controller/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -232,7 +232,7 @@ config PCI_HYPERV_INTERFACE 
	  driver.



config PCI_TEGRA

	bool "NVIDIA Tegra PCIe controller"

	tristate "NVIDIA Tegra PCIe controller"

	depends on ARCH_TEGRA || COMPILE_TEST

	depends on PCI_MSI

	select IRQ_MSI_LIB

drivers/pci/controller/pci-tegra.c

+4 −31
Original line number Diff line number Diff line
@@ -2545,12 +2545,6 @@ static const struct seq_operations tegra_pcie_ports_sops = { 


DEFINE_SEQ_ATTRIBUTE(tegra_pcie_ports);



static void tegra_pcie_debugfs_exit(struct tegra_pcie *pcie)

{

	debugfs_remove_recursive(pcie->debugfs);

	pcie->debugfs = NULL;

}



static void tegra_pcie_debugfs_init(struct tegra_pcie *pcie)

{

	pcie->debugfs = debugfs_create_dir("pcie", NULL);
@@ -2624,29 +2618,6 @@ static int tegra_pcie_probe(struct platform_device *pdev) 
	return err;

}



static void tegra_pcie_remove(struct platform_device *pdev)

{

	struct tegra_pcie *pcie = platform_get_drvdata(pdev);

	struct pci_host_bridge *host = pci_host_bridge_from_priv(pcie);

	struct tegra_pcie_port *port, *tmp;



	if (IS_ENABLED(CONFIG_DEBUG_FS))

		tegra_pcie_debugfs_exit(pcie);



	pci_stop_root_bus(host->bus);

	pci_remove_root_bus(host->bus);

	pm_runtime_put_sync(pcie->dev);

	pm_runtime_disable(pcie->dev);



	if (IS_ENABLED(CONFIG_PCI_MSI))

		tegra_pcie_msi_teardown(pcie);



	tegra_pcie_put_resources(pcie);



	list_for_each_entry_safe(port, tmp, &pcie->ports, list)

		tegra_pcie_port_free(port);

}



static int tegra_pcie_pm_suspend(struct device *dev)

{

	struct tegra_pcie *pcie = dev_get_drvdata(dev);
@@ -2750,6 +2721,8 @@ static struct platform_driver tegra_pcie_driver = { 
		.pm = &tegra_pcie_pm_ops,

	},

	.probe = tegra_pcie_probe,

	.remove = tegra_pcie_remove,

};

module_platform_driver(tegra_pcie_driver);
 
builtin_platform_driver(tegra_pcie_driver);

MODULE_AUTHOR("Thierry Reding <treding@nvidia.com>");

MODULE_DESCRIPTION("NVIDIA PCI host controller driver");

MODULE_LICENSE("GPL");