Commit aae757ec authored by Kalesh AP's avatar Kalesh AP Committed by Leon Romanovsky
Browse files

RDMA/bnxt_re: Remove unnecessary condition checks 



The check for "rdev" and "en_dev" pointer validity always
return false.

Remove them.

Reviewed-by: default avatarSaravanan Vajravel <saravanan.vajravel@broadcom.com>
Signed-off-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Link: https://patch.msgid.link/20250822040801.776196-11-kalesh-anakkur.purayil@broadcom.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 6133c131

drivers/infiniband/hw/bnxt_re/main.c

+1 −18
Original line number Diff line number Diff line
@@ -916,20 +916,12 @@ static void bnxt_re_deinitialize_dbr_pacing(struct bnxt_re_dev *rdev) 
static int bnxt_re_net_ring_free(struct bnxt_re_dev *rdev,

				 u16 fw_ring_id, int type)

{

	struct bnxt_en_dev *en_dev;

	struct bnxt_en_dev *en_dev = rdev->en_dev;

	struct hwrm_ring_free_input req = {};

	struct hwrm_ring_free_output resp;

	struct bnxt_fw_msg fw_msg = {};

	int rc = -EINVAL;



	if (!rdev)

		return rc;



	en_dev = rdev->en_dev;



	if (!en_dev)

		return rc;



	if (test_bit(BNXT_RE_FLAG_ERR_DEVICE_DETACHED, &rdev->flags))

		return 0;
@@ -955,9 +947,6 @@ static int bnxt_re_net_ring_alloc(struct bnxt_re_dev *rdev, 
	struct bnxt_fw_msg fw_msg = {};

	int rc = -EINVAL;



	if (!en_dev)

		return rc;



	bnxt_re_init_hwrm_hdr((void *)&req, HWRM_RING_ALLOC);

	req.enables = 0;

	req.page_tbl_addr =  cpu_to_le64(ring_attr->dma_arr[0]);
@@ -990,9 +979,6 @@ static int bnxt_re_net_stats_ctx_free(struct bnxt_re_dev *rdev, 
	struct bnxt_fw_msg fw_msg = {};

	int rc = -EINVAL;



	if (!en_dev)

		return rc;



	if (test_bit(BNXT_RE_FLAG_ERR_DEVICE_DETACHED, &rdev->flags))

		return 0;
@@ -1020,9 +1006,6 @@ static int bnxt_re_net_stats_ctx_alloc(struct bnxt_re_dev *rdev, 


	stats->fw_id = INVALID_STATS_CTX_ID;



	if (!en_dev)

		return rc;



	bnxt_re_init_hwrm_hdr((void *)&req, HWRM_STAT_CTX_ALLOC);

	req.update_period_ms = cpu_to_le32(1000);

	req.stats_dma_addr = cpu_to_le64(stats->dma_map);