Unverified Commit aba2a144 authored by Miguel Ojeda's avatar Miguel Ojeda Committed by Maxime Ripard
Browse files

drm/qxl: remove unused variable from `qxl_process_single_command()` 

Clang 14 in an (essentially) defconfig loongarch64 build for next-20240327
reports [1]:

     drivers/gpu/drm/qxl/qxl_ioctl.c:148:14: error: variable 'num_relocs'
     set but not used [-Werror,-Wunused-but-set-variable]

The variable was originally used in the `out_free_bos` label, but commit
74d9a633 ("drm/qxl: Simplify cleaning qxl processing command")
removed the use that happened in that label.

Thus remove the unused variable.

Fixes: 74d9a633 ("drm/qxl: Simplify cleaning qxl processing command")
Closes: https://lore.kernel.org/lkml/CANiq72kqqQfUxLkHJYqeBAhpc6YcX7bfR96gmmbF=j8hEOykqw@mail.gmail.com/

 [1]
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
Link: https://lore.kernel.org/r/20240327175556.233126-2-ojeda@kernel.org


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent 7cd78fd7

drivers/gpu/drm/qxl/qxl_ioctl.c

+1 −3
Original line number Diff line number Diff line
@@ -145,7 +145,7 @@ static int qxl_process_single_command(struct qxl_device *qdev, 
	struct qxl_release *release;

	struct qxl_bo *cmd_bo;

	void *fb_cmd;

	int i, ret, num_relocs;

	int i, ret;

	int unwritten;



	switch (cmd->type) {
@@ -200,7 +200,6 @@ static int qxl_process_single_command(struct qxl_device *qdev, 
	}



	/* fill out reloc info structs */

	num_relocs = 0;

	for (i = 0; i < cmd->relocs_num; ++i) {

		struct drm_qxl_reloc reloc;

		struct drm_qxl_reloc __user *u = u64_to_user_ptr(cmd->relocs);
@@ -230,7 +229,6 @@ static int qxl_process_single_command(struct qxl_device *qdev, 
			reloc_info[i].dst_bo = cmd_bo;

			reloc_info[i].dst_offset = reloc.dst_offset + release->release_offset;

		}

		num_relocs++;



		/* reserve and validate the reloc dst bo */

		if (reloc.reloc_type == QXL_RELOC_TYPE_BO || reloc.src_handle) {