Commit abb1f08a authored Sep 30, 2025 by Chuck Lever

NFSD: Fix crash in nfsd4_read_release()



When tracing is enabled, the trace_nfsd_read_done trace point
crashes during the pynfs read.testNoFh test.

Fixes: 15a8b55d ("nfsd: call op_release, even when op_func returns an error")
Cc: stable@vger.kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

parent 4f76435f

fs/nfsd/nfs4proc.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -988,10 +988,11 @@ nfsd4_read(struct svc_rqst rqstp, struct nfsd4_compound_state cstate,
		static void
		nfsd4_read_release(union nfsd4_op_u *u)
		{
		if (u->read.rd_nf)
		nfsd_file_put(u->read.rd_nf);
		if (u->read.rd_nf) {
		trace_nfsd_read_done(u->read.rd_rqstp, u->read.rd_fhp,
		u->read.rd_offset, u->read.rd_length);
		nfsd_file_put(u->read.rd_nf);
		}
		}

		static __be32