Commit ac29d8ae authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: ump: Force 1 Group for MIDI1 FBs 

When a Function Block declares it being a legacy MIDI1 device, it has
to be only with a single UMP Group.  Correct the attribute when a
device declares it wrongly.

Fixes: 37e0e141 ("ALSA: ump: Support UMP Endpoint and Function Block parsing")
Cc: <stable@vger.kernel.org>
Link: https://patch.msgid.link/20240722140610.10845-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9a4ab167

sound/core/ump.c

+6 −0
Original line number Diff line number Diff line
@@ -733,6 +733,12 @@ static void fill_fb_info(struct snd_ump_endpoint *ump, 
		info->block_id, info->direction, info->active,

		info->first_group, info->num_groups, info->midi_ci_version,

		info->sysex8_streams, info->flags);



	if ((info->flags & SNDRV_UMP_BLOCK_IS_MIDI1) && info->num_groups != 1) {

		info->num_groups = 1;

		ump_dbg(ump, "FB %d: corrected groups to 1 for MIDI1\n",

			info->block_id);

	}

}



/* check whether the FB info gets updated by the current message */