Commit ac2efaa8 authored by Ethan Carter Edwards's avatar Ethan Carter Edwards Committed by Ard Biesheuvel
Browse files

efi: efibc: change kmalloc(size * count, ...) to kmalloc_array() 

Open coded arithmetic in allocator arguments is discouraged. Helper
functions like kcalloc or, in this case, kmalloc_array are preferred.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments



Signed-off-by: default avatarEthan Carter Edwards <ethan@ethancedwards.com>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent b6b227e3

drivers/firmware/efi/efibc.c

+1 −1
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ static int efibc_reboot_notifier_call(struct notifier_block *notifier, 
	if (ret || !data)

		return NOTIFY_DONE;



	wdata = kmalloc(MAX_DATA_LEN * sizeof(efi_char16_t), GFP_KERNEL);

	wdata = kmalloc_array(MAX_DATA_LEN, sizeof(efi_char16_t), GFP_KERNEL);

	if (!wdata)

		return NOTIFY_DONE;