Commit ac95b1fc authored by Jiri Pirko's avatar Jiri Pirko Committed by Jakub Kicinski
Browse files

tools: ynl: allow user to specify flag attr with bool values 



The flag attr presence in Netlink message indicates value "true",
if it is missing in the message it means "false".

Allow user to specify attrname with value "true"/"false"
in json for flag attrs, treat "false" value properly.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarDonald Hunter <donald.hunter@gmail.com>
Link: https://lore.kernel.org/r/20240222134351.224704-2-jiri@resnulli.us


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5c4e0f3a

tools/net/ynl/lib/ynl.py

+3 −0
Original line number Diff line number Diff line
@@ -459,6 +459,9 @@ class YnlFamily(SpecFamily): 
                attr_payload += self._add_attr(attr['nested-attributes'],

                                               subname, subvalue, sub_attrs)

        elif attr["type"] == 'flag':

            if not value:

                # If value is absent or false then skip attribute creation.

                return b''

            attr_payload = b''

        elif attr["type"] == 'string':

            attr_payload = str(value).encode('ascii') + b'\x00'