Commit ad320e40 authored by Henry Martin's avatar Henry Martin Committed by Damien Le Moal
Browse files

ata: pata_pxa: Fix potential NULL pointer dereference in pxa_ata_probe() 



devm_ioremap() returns NULL on error. Currently, pxa_ata_probe() does
not check for this case, which can result in a NULL pointer dereference.

Add NULL check after devm_ioremap() to prevent this issue.

Fixes: 2dc6c6f1 ("[ARM] pata_pxa: DMA-capable PATA driver")
Signed-off-by: default avatarHenry Martin <bsdhenrymartin@gmail.com>
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
parent 0af2f6be

drivers/ata/pata_pxa.c

+6 −0
Original line number Diff line number Diff line
@@ -223,10 +223,16 @@ static int pxa_ata_probe(struct platform_device *pdev) 


	ap->ioaddr.cmd_addr	= devm_ioremap(&pdev->dev, cmd_res->start,

						resource_size(cmd_res));

	if (!ap->ioaddr.cmd_addr)

		return -ENOMEM;

	ap->ioaddr.ctl_addr	= devm_ioremap(&pdev->dev, ctl_res->start,

						resource_size(ctl_res));

	if (!ap->ioaddr.ctl_addr)

		return -ENOMEM;

	ap->ioaddr.bmdma_addr	= devm_ioremap(&pdev->dev, dma_res->start,

						resource_size(dma_res));

	if (!ap->ioaddr.bmdma_addr)

		return -ENOMEM;



	/*

	 * Adjust register offsets