Commit adcdaac5 authored by Antonio Quartulli's avatar Antonio Quartulli
Browse files

ovpn: drop useless reg_state check in keepalive worker 



The keepalive worker is cancelled before calling
unregister_netdevice_queue(), therefore it will never
hit a situation where the reg_state can be different
than NETDEV_REGISTERED.

For this reason, checking reg_state is useless and the
condition can be removed.

Signed-off-by: default avatarAntonio Quartulli <antonio@openvpn.net>
parent 944f8b6a

drivers/net/ovpn/peer.c

+1 −2
Original line number Diff line number Diff line
@@ -1353,8 +1353,7 @@ void ovpn_peer_keepalive_work(struct work_struct *work) 
	}



	/* prevent rearming if the interface is being destroyed */

	if (next_run > 0 &&

	    READ_ONCE(ovpn->dev->reg_state) == NETREG_REGISTERED) {

	if (next_run > 0) {

		netdev_dbg(ovpn->dev,

			   "scheduling keepalive work: now=%llu next_run=%llu delta=%llu\n",

			   next_run, now, next_run - now);