Commit ae1b6b4c authored by Wolfram Sang's avatar Wolfram Sang Committed by Greg Kroah-Hartman
Browse files

serial: sh-sci: simplify locking when re-issuing RXDMA fails 



Avoid a superfluous unlock/lock-pair by simply moving the printout to
the end of bailing out.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240506114016.30498-10-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0c9c1ea5

drivers/tty/serial/sh-sci.c

+1 −3
Original line number Diff line number Diff line
@@ -1360,14 +1360,12 @@ static void sci_dma_rx_complete(void *arg) 
	return;



fail:

	uart_port_unlock_irqrestore(port, flags);

	dev_warn(port->dev, "Failed submitting Rx DMA descriptor\n");

	/* Switch to PIO */

	uart_port_lock_irqsave(port, &flags);

	dmaengine_terminate_async(chan);

	sci_dma_rx_chan_invalidate(s);

	sci_dma_rx_reenable_irq(s);

	uart_port_unlock_irqrestore(port, flags);

	dev_warn(port->dev, "Failed submitting Rx DMA descriptor\n");

}



static void sci_dma_tx_release(struct sci_port *s)