Commit ae4744e1 authored by Jian Zhang's avatar Jian Zhang Committed by Jakub Kicinski
Browse files

net: mctp-i2c: fix duplicate reception of old data 



The MCTP I2C slave callback did not handle I2C_SLAVE_READ_REQUESTED
events. As a result, i2c read event will trigger repeated reception of
old data, reset rx_pos when a read request is received.

Signed-off-by: default avatarJian Zhang <zhangjian.3032@bytedance.com>
Link: https://patch.msgid.link/20260108101829.1140448-1-zhangjian.3032@bytedance.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent aab8aa1b

drivers/net/mctp/mctp-i2c.c

+6 −0
Original line number Diff line number Diff line
@@ -242,6 +242,9 @@ static int mctp_i2c_slave_cb(struct i2c_client *client, 
		return 0;



	switch (event) {

	case I2C_SLAVE_READ_REQUESTED:

		midev->rx_pos = 0;

		break;

	case I2C_SLAVE_WRITE_RECEIVED:

		if (midev->rx_pos < MCTP_I2C_BUFSZ) {

			midev->rx_buffer[midev->rx_pos] = *val;
@@ -279,6 +282,9 @@ static int mctp_i2c_recv(struct mctp_i2c_dev *midev) 
	size_t recvlen;

	int status;



	if (midev->rx_pos == 0)

		return 0;



	/* + 1 for the PEC */

	if (midev->rx_pos < MCTP_I2C_MINLEN + 1) {

		ndev->stats.rx_length_errors++;