Commit ae4789af authored by Meghana Malladi's avatar Meghana Malladi Committed by Jakub Kicinski
Browse files

net: ti: icssg-prueth: Fix fdb hash size configuration 

The ICSSG driver does the initial FDB configuration which
includes setting the control registers. Other run time
management like learning is managed by the PRU's. The default
FDB hash size used by the firmware is 512 slots, which is
currently missing in the current driver. Update the driver
FDB config to include FDB hash size as well.

Please refer trm [1] 6.4.14.12.17 section on how the FDB config
register gets configured. From the table 6-1404, there is a reset
field for FDB_HAS_SIZE which is 4, meaning 1024 slots. Currently
the driver is not updating this reset value from 4(1024 slots) to
3(512 slots). This patch fixes this by updating the reset value
to 512 slots.

[1]: https://www.ti.com/lit/pdf/spruim2


Fixes: abd5576b ("net: ti: icssg-prueth: Add support for ICSSG switch firmware")
Signed-off-by: default avatarMeghana Malladi <m-malladi@ti.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251104104415.3110537-1-m-malladi@ti.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d1c94bc5

drivers/net/ethernet/ti/icssg/icssg_config.c

+7 −0
Original line number Diff line number Diff line
@@ -66,6 +66,9 @@ 
#define FDB_GEN_CFG1		0x60

#define SMEM_VLAN_OFFSET	8

#define SMEM_VLAN_OFFSET_MASK	GENMASK(25, 8)

#define FDB_HASH_SIZE_MASK	GENMASK(6, 3)

#define FDB_HASH_SIZE_SHIFT	3

#define FDB_HASH_SIZE		3



#define FDB_GEN_CFG2		0x64

#define FDB_VLAN_EN		BIT(6)
@@ -463,6 +466,8 @@ void icssg_init_emac_mode(struct prueth *prueth) 
	/* Set VLAN TABLE address base */

	regmap_update_bits(prueth->miig_rt, FDB_GEN_CFG1, SMEM_VLAN_OFFSET_MASK,

			   addr <<  SMEM_VLAN_OFFSET);

	regmap_update_bits(prueth->miig_rt, FDB_GEN_CFG1, FDB_HASH_SIZE_MASK,

			   FDB_HASH_SIZE << FDB_HASH_SIZE_SHIFT);

	/* Set enable VLAN aware mode, and FDBs for all PRUs */

	regmap_write(prueth->miig_rt, FDB_GEN_CFG2, (FDB_PRU0_EN | FDB_PRU1_EN | FDB_HOST_EN));

	prueth->vlan_tbl = (struct prueth_vlan_tbl __force *)(prueth->shram.va +
@@ -484,6 +489,8 @@ void icssg_init_fw_offload_mode(struct prueth *prueth) 
	/* Set VLAN TABLE address base */

	regmap_update_bits(prueth->miig_rt, FDB_GEN_CFG1, SMEM_VLAN_OFFSET_MASK,

			   addr <<  SMEM_VLAN_OFFSET);

	regmap_update_bits(prueth->miig_rt, FDB_GEN_CFG1, FDB_HASH_SIZE_MASK,

			   FDB_HASH_SIZE << FDB_HASH_SIZE_SHIFT);

	/* Set enable VLAN aware mode, and FDBs for all PRUs */

	regmap_write(prueth->miig_rt, FDB_GEN_CFG2, FDB_EN_ALL);

	prueth->vlan_tbl = (struct prueth_vlan_tbl __force *)(prueth->shram.va +