Commit aeca1756 authored by William Breathitt Gray's avatar William Breathitt Gray Committed by Bartosz Golaszewski
Browse files

gpio: pci-idio-16: Replace deprecated PCI functions 



pcim_iomap_regions() and pcim_iomap_table() have been deprecated in
commit e354bb84 ("PCI: Deprecate pcim_iomap_table(),
pcim_iomap_regions_request_all()"). Replace these functions with
pcim_iomap_region().

In order to match the rest of the code in idio_16_probe(), utilize
dev_err_probe() to handle error for pcim_enable_device().

Signed-off-by: default avatarWilliam Breathitt Gray <wbg@kernel.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20241101-pci_iomap_region_gpio_acces-v1-1-26eb1dc93e45@kernel.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent dae01ec7

drivers/gpio/gpio-pci-idio-16.c

+5 −12
Original line number Diff line number Diff line
@@ -70,24 +70,17 @@ static int idio_16_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	struct device *const dev = &pdev->dev;

	int err;

	const size_t pci_bar_index = 2;

	const char *const name = pci_name(pdev);

	struct idio_16_regmap_config config = {};

	void __iomem *regs;

	struct regmap *map;



	err = pcim_enable_device(pdev);

	if (err) {

		dev_err(dev, "Failed to enable PCI device (%d)\n", err);

		return err;

	}



	err = pcim_iomap_regions(pdev, BIT(pci_bar_index), name);

	if (err) {

		dev_err(dev, "Unable to map PCI I/O addresses (%d)\n", err);

		return err;

	}

	if (err)

		return dev_err_probe(dev, err, "Failed to enable PCI device\n");



	regs = pcim_iomap_table(pdev)[pci_bar_index];

	regs = pcim_iomap_region(pdev, pci_bar_index, pci_name(pdev));

	if (IS_ERR(regs))

		return dev_err_probe(dev, PTR_ERR(regs), "Unable to map PCI I/O addresses\n");



	map = devm_regmap_init_mmio(dev, regs, &idio_16_regmap_config);

	if (IS_ERR(map))