Commit aef656a0 authored by Julian Braha's avatar Julian Braha Committed by Madhavan Srinivasan
Browse files

powerpc: fix dead default for GUEST_STATE_BUFFER_TEST 



The GUEST_STATE_BUFFER_TEST config option should default
to KUNIT_ALL_TESTS so that if all tests are enabled then
it is included, but currently the 'default KUNIT_ALL_TESTS'
statement is shadowed by 'def_tristate n',
meaning that this second default statement is currently dead code.

It looks to me like the commit
6ccbbc33 ("KVM: PPC: Add helper library for Guest State Buffers")
intended to set the default to KUNIT_ALL_TESTS, but mistakenly
missed the def_tristate.

This dead code was found by kconfirm, a static analysis tool for Kconfig.

Fixes: 6ccbbc33 ("KVM: PPC: Add helper library for Guest State Buffers")
Signed-off-by: default avatarJulian Braha <julianbraha@gmail.com>
Tested-by: default avatarGautam Menghani <gautam@linux.ibm.com>
Reviewed-by: default avatarAmit Machhiwal <amachhiw@linux.ibm.com>
Reviewed-by: default avatarHarsh Prateek Bora <harshpb@linux.ibm.com>
Signed-off-by: default avatarMadhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20260405161545.161006-1-julianbraha@gmail.com
parent f98020c2

arch/powerpc/Kconfig.debug

+1 −2
Original line number Diff line number Diff line
@@ -83,11 +83,10 @@ config MSI_BITMAP_SELFTEST 
	depends on DEBUG_KERNEL



config GUEST_STATE_BUFFER_TEST

	def_tristate n

	def_tristate KUNIT_ALL_TESTS

	prompt "Enable Guest State Buffer unit tests"

	depends on KUNIT

	depends on KVM_BOOK3S_HV_POSSIBLE

	default KUNIT_ALL_TESTS

	help

	  The Guest State Buffer is a data format specified in the PAPR.

	  It is by hcalls to communicate the state of L2 guests between