Commit af241e6b authored by Benjamin Block's avatar Benjamin Block Committed by Heiko Carstens
Browse files

s390/pci: Annotate lock context imbalance in zpci_release_device() 



When checking `arch/s390/pci/pci.c` with `sparse` during build, the
following complaint is reported:

  arch/s390/pci/pci.c: note: in included file (through include/linux/smp.h, include/linux/lockdep.h, include/linux/spinlock.h, include/linux/mmzone.h, include/linux/gfp.h, include/linux/slab.h):
  ./include/linux/list.h:237:25: warning: context imbalance in 'zpci_release_device' - unexpected unlock

But this is expected, as zpci_release_device() is expected to be called
with `zpci_list_lock` held, as part of `kref_put_lock()` or similar.

Reflect this by annotating the function with the appropriate
__releases().

Signed-off-by: default avatarBenjamin Block <bblock@linux.ibm.com>
Reviewed-by: default avatarFarhan Ali <alifm@linux.ibm.com>
Reviewed-by: default avatarNiklas Schnelle <schnelle@linux.ibm.com>
Reviewed-by: default avatarGerd Bayer <gbayer@linux.ibm.com>
Signed-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
parent 4cb92fa7

arch/s390/pci/pci.c

+1 −0
Original line number Diff line number Diff line
@@ -961,6 +961,7 @@ void zpci_device_reserved(struct zpci_dev *zdev) 
}



void zpci_release_device(struct kref *kref)

	__releases(&zpci_list_lock)

{

	struct zpci_dev *zdev = container_of(kref, struct zpci_dev, kref);