Commit af264e59 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Miquel Raynal
Browse files

mtd: spinand: Constify struct nand_ecc_engine_ops 



'struct nand_ecc_engine_ops' are not modified in these drivers.

Constifying this structure moves some data to a read-only section, so
increases overall security, especially when the structure holds some
function pointers.

Update the prototype of mxic_ecc_get_pipelined_ops() accordingly.

On a x86_64, with allmodconfig, as an example:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  16709	   1374	     16	  18099	   46b3	drivers/mtd/nand/ecc-mxic.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  16789	   1294	     16	  18099	   46b3	drivers/mtd/nand/ecc-mxic.o

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/72597e9de2320a4109be2112e696399592edacd4.1729271136.git.christophe.jaillet@wanadoo.fr
parent 7b2e57c2

drivers/mtd/nand/ecc-mxic.c

+3 −3
Original line number Diff line number Diff line
@@ -723,21 +723,21 @@ static int mxic_ecc_finish_io_req_pipelined(struct nand_device *nand, 
	return ret;

}



static struct nand_ecc_engine_ops mxic_ecc_engine_external_ops = {

static const struct nand_ecc_engine_ops mxic_ecc_engine_external_ops = {

	.init_ctx = mxic_ecc_init_ctx_external,

	.cleanup_ctx = mxic_ecc_cleanup_ctx,

	.prepare_io_req = mxic_ecc_prepare_io_req_external,

	.finish_io_req = mxic_ecc_finish_io_req_external,

};



static struct nand_ecc_engine_ops mxic_ecc_engine_pipelined_ops = {

static const struct nand_ecc_engine_ops mxic_ecc_engine_pipelined_ops = {

	.init_ctx = mxic_ecc_init_ctx_pipelined,

	.cleanup_ctx = mxic_ecc_cleanup_ctx,

	.prepare_io_req = mxic_ecc_prepare_io_req_pipelined,

	.finish_io_req = mxic_ecc_finish_io_req_pipelined,

};



struct nand_ecc_engine_ops *mxic_ecc_get_pipelined_ops(void)

const struct nand_ecc_engine_ops *mxic_ecc_get_pipelined_ops(void)

{

	return &mxic_ecc_engine_pipelined_ops;

}

drivers/mtd/nand/ecc-sw-bch.c

+1 −1
Original line number Diff line number Diff line
@@ -384,7 +384,7 @@ static int nand_ecc_sw_bch_finish_io_req(struct nand_device *nand, 
	return max_bitflips;

}



static struct nand_ecc_engine_ops nand_ecc_sw_bch_engine_ops = {

static const struct nand_ecc_engine_ops nand_ecc_sw_bch_engine_ops = {

	.init_ctx = nand_ecc_sw_bch_init_ctx,

	.cleanup_ctx = nand_ecc_sw_bch_cleanup_ctx,

	.prepare_io_req = nand_ecc_sw_bch_prepare_io_req,

drivers/mtd/nand/ecc-sw-hamming.c

+1 −1
Original line number Diff line number Diff line
@@ -638,7 +638,7 @@ static int nand_ecc_sw_hamming_finish_io_req(struct nand_device *nand, 
	return max_bitflips;

}



static struct nand_ecc_engine_ops nand_ecc_sw_hamming_engine_ops = {

static const struct nand_ecc_engine_ops nand_ecc_sw_hamming_engine_ops = {

	.init_ctx = nand_ecc_sw_hamming_init_ctx,

	.cleanup_ctx = nand_ecc_sw_hamming_cleanup_ctx,

	.prepare_io_req = nand_ecc_sw_hamming_prepare_io_req,

drivers/mtd/nand/spi/core.c

+1 −1
Original line number Diff line number Diff line
@@ -337,7 +337,7 @@ static int spinand_ondie_ecc_finish_io_req(struct nand_device *nand, 
	return ret;

}



static struct nand_ecc_engine_ops spinand_ondie_ecc_engine_ops = {

static const struct nand_ecc_engine_ops spinand_ondie_ecc_engine_ops = {

	.init_ctx = spinand_ondie_ecc_init_ctx,

	.cleanup_ctx = spinand_ondie_ecc_cleanup_ctx,

	.prepare_io_req = spinand_ondie_ecc_prepare_io_req,

drivers/spi/spi-mtk-snfi.c

+1 −1
Original line number Diff line number Diff line
@@ -776,7 +776,7 @@ static int mtk_snand_ecc_finish_io_req(struct nand_device *nand, 
	return snf->ecc_stats.failed ? -EBADMSG : snf->ecc_stats.bitflips;

}



static struct nand_ecc_engine_ops mtk_snfi_ecc_engine_ops = {

static const struct nand_ecc_engine_ops mtk_snfi_ecc_engine_ops = {

	.init_ctx = mtk_snand_ecc_init_ctx,

	.cleanup_ctx = mtk_snand_ecc_cleanup_ctx,

	.prepare_io_req = mtk_snand_ecc_prepare_io_req,