Commit b04974f7 authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcachefs: Fix srcu lock warning in btree_update_nodes_written() 



We don't want to be holding the srcu lock while waiting on btree write
completions - easily fixed.

Reported-by: default avatarJanpieter Sollie <janpieter.sollie@edpnet.be>
Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent 4fd509c1

fs/bcachefs/btree_update_interior.c

+2 −0
Original line number Diff line number Diff line
@@ -681,9 +681,11 @@ static void btree_update_nodes_written(struct btree_update *as) 


		b = as->old_nodes[i];



		bch2_trans_begin(trans);

		btree_node_lock_nopath_nofail(trans, &b->c, SIX_LOCK_read);

		seq = b->data ? b->data->keys.seq : 0;

		six_unlock_read(&b->c.lock);

		bch2_trans_unlock_long(trans);



		if (seq == as->old_nodes_seq[i])

			wait_on_bit_io(&b->flags, BTREE_NODE_write_in_flight_inner,