Commit b051ffa2 authored by Vicki Pfau's avatar Vicki Pfau Committed by Jiri Kosina
Browse files

HID: hid-steam: Don't use cancel_delayed_work_sync in IRQ context 



Lockdep reported that, as steam_do_deck_input_event is called from
steam_raw_event inside of an IRQ context, it can lead to issues if that IRQ
occurs while the work to be cancelled is running. By using cancel_delayed_work,
this issue can be avoided. The exact ordering of the work and the event
processing is not super important, so this is safe.

Fixes: cd438e57 ("HID: hid-steam: Add gamepad-only mode switched to by holding options")
Signed-off-by: default avatarVicki Pfau <vi@endrift.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 79504249

drivers/hid/hid-steam.c

+1 −1
Original line number Diff line number Diff line
@@ -1617,7 +1617,7 @@ static void steam_do_deck_input_event(struct steam_device *steam, 


	if (!(b9 & BIT(6)) && steam->did_mode_switch) {

		steam->did_mode_switch = false;

		cancel_delayed_work_sync(&steam->mode_switch);

		cancel_delayed_work(&steam->mode_switch);

	} else if (!steam->client_opened && (b9 & BIT(6)) && !steam->did_mode_switch) {

		steam->did_mode_switch = true;

		schedule_delayed_work(&steam->mode_switch, 45 * HZ / 100);