Commit b08d86e6 authored by ChanWoo Lee's avatar ChanWoo Lee Committed by Martin K. Petersen
Browse files

scsi: ufs: qcom: Remove unnecessary goto statement from ufs_qcom_config_esi() 



There is only one place where goto is used, and it is unnecessary to check
the ret value through 'goto out' because the ret value is already true.

Therefore, remove the goto statement and integrate the '!ret' condition
into the existing code.

Signed-off-by: default avatarChanWoo Lee <cw9316.lee@samsung.com>
Link: https://lore.kernel.org/r/20231219082740.27644-1-cw9316.lee@samsung.com


Reviewed-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent ee367109

drivers/ufs/host/ufs-qcom.c

+2 −5
Original line number Diff line number Diff line
@@ -1714,7 +1714,7 @@ static int ufs_qcom_config_esi(struct ufs_hba *hba) 
					     ufs_qcom_write_msi_msg);

	if (ret) {

		dev_err(hba->dev, "Failed to request Platform MSI %d\n", ret);

		goto out;

		return ret;

	}



	msi_lock_descs(hba->dev);
@@ -1748,11 +1748,8 @@ static int ufs_qcom_config_esi(struct ufs_hba *hba) 
				    FIELD_PREP(ESI_VEC_MASK, MAX_ESI_VEC - 1),

				    REG_UFS_CFG3);

		ufshcd_mcq_enable_esi(hba);

	}



out:

	if (!ret)

		host->esi_enabled = true;

	}



	return ret;

}