Commit b0f0e3f0 authored by Ma Ke's avatar Ma Ke Committed by Linus Walleij
Browse files

pinctrl: stm32: check devm_kasprintf() returned value 



devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: 32c170ff ("pinctrl: stm32: set default gpio line names using pin names")
Signed-off-by: default avatarMa Ke <make24@iscas.ac.cn>
Link: https://lore.kernel.org/20240906100326.624445-1-make24@iscas.ac.cn


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 665a58fe

drivers/pinctrl/stm32/pinctrl-stm32.c

+7 −2
Original line number Diff line number Diff line
@@ -1374,11 +1374,16 @@ static int stm32_gpiolib_register_bank(struct stm32_pinctrl *pctl, struct fwnode 


	for (i = 0; i < npins; i++) {

		stm32_pin = stm32_pctrl_get_desc_pin_from_gpio(pctl, bank, i);

		if (stm32_pin && stm32_pin->pin.name)

		if (stm32_pin && stm32_pin->pin.name) {

			names[i] = devm_kasprintf(dev, GFP_KERNEL, "%s", stm32_pin->pin.name);

		else

			if (!names[i]) {

				err = -ENOMEM;

				goto err_clk;

			}

		} else {

			names[i] = NULL;

		}

	}



	bank->gpio_chip.names = (const char * const *)names;