Commit b0f7b956 authored by Ryder Lee's avatar Ryder Lee Committed by Felix Fietkau
Browse files

wifi: mt76: mt7915: drop always true condition of __mt7915_reg_addr() 



smatch warnings:
addr <= MT_CBTOP2_PHY_END(0xffffffff) is always true (<= u32max),
so drop it.

Fixes: cd4c314a ("mt76: mt7915: refine register definition")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarRyder Lee <ryder.lee@mediatek.com>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 7a53eecd

drivers/net/wireless/mediatek/mt76/mt7915/mmio.c

+1 −1
Original line number Diff line number Diff line
@@ -495,7 +495,7 @@ static u32 __mt7915_reg_addr(struct mt7915_dev *dev, u32 addr) 


	if (dev_is_pci(dev->mt76.dev) &&

	    ((addr >= MT_CBTOP1_PHY_START && addr <= MT_CBTOP1_PHY_END) ||

	     (addr >= MT_CBTOP2_PHY_START && addr <= MT_CBTOP2_PHY_END)))

	    addr >= MT_CBTOP2_PHY_START))

		return mt7915_reg_map_l1(dev, addr);



	/* CONN_INFRA: covert to phyiscal addr and use layer 1 remap */

drivers/net/wireless/mediatek/mt76/mt7915/regs.h

+0 −1
Original line number Diff line number Diff line
@@ -803,7 +803,6 @@ enum offs_rev { 
#define MT_CBTOP1_PHY_START		0x70000000

#define MT_CBTOP1_PHY_END		__REG(CBTOP1_PHY_END)

#define MT_CBTOP2_PHY_START		0xf0000000

#define MT_CBTOP2_PHY_END		0xffffffff

#define MT_INFRA_MCU_START		0x7c000000

#define MT_INFRA_MCU_END		__REG(INFRA_MCU_ADDR_END)

#define MT_CONN_INFRA_OFFSET(p)		((p) - MT_INFRA_BASE)