Commit b169b376 authored by Corentin Labbe's avatar Corentin Labbe Committed by Herbert Xu
Browse files

crypto: sun8i-ss - call finalize with bh disabled 



Doing ipsec produces a spinlock recursion warning.
This is due to not disabling BH during crypto completion function.

Fixes: f08fcced ("crypto: allwinner - Add sun8i-ss cryptographic offloader")
Signed-off-by: default avatarCorentin Labbe <clabbe@baylibre.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 2f5ee72e

drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c

+3 −0
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ 
 * You could find a link for the datasheet in Documentation/arm/sunxi.rst

 */



#include <linux/bottom_half.h>

#include <linux/crypto.h>

#include <linux/dma-mapping.h>

#include <linux/io.h>
@@ -274,7 +275,9 @@ static int sun8i_ss_handle_cipher_request(struct crypto_engine *engine, void *ar 
	struct skcipher_request *breq = container_of(areq, struct skcipher_request, base);



	err = sun8i_ss_cipher(breq);

	local_bh_disable();

	crypto_finalize_skcipher_request(engine, breq, err);

	local_bh_enable();



	return 0;

}

drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c

+3 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
 *

 * You could find the datasheet in Documentation/arm/sunxi.rst

 */

#include <linux/bottom_half.h>

#include <linux/dma-mapping.h>

#include <linux/pm_runtime.h>

#include <linux/scatterlist.h>
@@ -442,6 +443,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq) 
theend:

	kfree(pad);

	kfree(result);

	local_bh_disable();

	crypto_finalize_hash_request(engine, breq, err);

	local_bh_enable();

	return 0;

}