Commit b1b26ce8 authored by Chun-Tse Shao's avatar Chun-Tse Shao Committed by Arnaldo Carvalho de Melo
Browse files

perf session: Skip unsupported new event types 



`perf report` currently halts with an error when encountering
unsupported new event types (`event.type >= PERF_RECORD_HEADER_MAX`).

This patch modifies the behavior to skip these samples and continue
processing the remaining events.

Additionally, stops reporting if the new event size is not 8-byte
aligned.

Suggested-by: default avatarArnaldo Carvalho de Melo <acme@kernel.org>
Suggested-by: default avatarNamhyung Kim <namhyung@kernel.org>
Reviewed-by: default avatarIan Rogers <irogers@google.com>
Signed-off-by: default avatarChun-Tse Shao <ctshao@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ben Gainey <ben.gainey@arm.com>
Cc: Dmitriy Vyukov <dvyukov@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250414173921.2905822-1-ctshao@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 0ef8091f

tools/perf/util/session.c

+11 −2
Original line number Diff line number Diff line
@@ -1639,9 +1639,18 @@ static s64 perf_session__process_event(struct perf_session *session, 
	if (session->header.needs_swap)

		event_swap(event, evlist__sample_id_all(evlist));



	if (event->header.type >= PERF_RECORD_HEADER_MAX)

	if (event->header.type >= PERF_RECORD_HEADER_MAX) {

		/* perf should not support unaligned event, stop here. */

		if (event->header.size % sizeof(u64))

			return -EINVAL;



		/* This perf is outdated and does not support the latest event type. */

		ui__warning("Unsupported header type %u, please consider updating perf.\n",

			    event->header.type);

		/* Skip unsupported event by returning its size. */

		return event->header.size;

	}



	events_stats__inc(&evlist->stats, event->header.type);



	if (event->header.type >= PERF_RECORD_USER_TYPE_START)