Commit b2516f7a authored by Gary Guo's avatar Gary Guo Committed by Miguel Ojeda
Browse files

rust: kernel: remove `#[allow(clippy::new_ret_no_self)]` 



Clippy triggered a false positive on its `new_ret_no_self` lint
when using the `pin_init!` macro. Since Rust 1.67.0, that does
not happen anymore, since Clippy learnt to not warn about
`-> impl Trait<Self>` [1][2].

The kernel nowadays uses Rust 1.72.1, thus remove the `#[allow]`.

Signed-off-by: default avatarGary Guo <gary@garyguo.net>
Reviewed-by: default avatarAlice Ryhl <aliceryhl@google.com>
Reviewed-by: default avatarBenno Lossin <benno.lossin@proton.me>
Reviewed-by: default avatarFinn Behrens <me@kloenk.dev>
Reviewed-by: default avatarMartin Rodriguez Reboredo <yakoyoku@gmail.com>
Link: https://github.com/rust-lang/rust-clippy/issues/7344 [1]
Link: https://github.com/rust-lang/rust-clippy/pull/9733 [2]
Link: https://lore.kernel.org/r/20230923024707.47610-1-gary@garyguo.net


[ Reworded slightly and added a couple `Link`s. ]
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent fc388bea

rust/kernel/init.rs

+10 −10
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ 
//! that you need to write `<-` instead of `:` for fields that you want to initialize in-place.

//!

//! ```rust

//! # #![allow(clippy::disallowed_names, clippy::new_ret_no_self)]

//! # #![allow(clippy::disallowed_names)]

//! use kernel::{prelude::*, sync::Mutex, new_mutex};

//! # use core::pin::Pin;

//! #[pin_data]
@@ -55,7 +55,7 @@ 
//! (or just the stack) to actually initialize a `Foo`:

//!

//! ```rust

//! # #![allow(clippy::disallowed_names, clippy::new_ret_no_self)]

//! # #![allow(clippy::disallowed_names)]

//! # use kernel::{prelude::*, sync::Mutex, new_mutex};

//! # use core::pin::Pin;

//! # #[pin_data]
@@ -86,7 +86,7 @@ 
//! To declare an init macro/function you just return an [`impl PinInit<T, E>`]:

//!

//! ```rust

//! # #![allow(clippy::disallowed_names, clippy::new_ret_no_self)]

//! # #![allow(clippy::disallowed_names)]

//! # use kernel::{sync::Mutex, prelude::*, new_mutex, init::PinInit, try_pin_init};

//! #[pin_data]

//! struct DriverData {
@@ -236,7 +236,7 @@ 
/// # Examples

///

/// ```rust

/// # #![allow(clippy::disallowed_names, clippy::new_ret_no_self)]

/// # #![allow(clippy::disallowed_names)]

/// # use kernel::{init, macros::pin_data, pin_init, stack_pin_init, init::*, sync::Mutex, new_mutex};

/// # use core::pin::Pin;

/// #[pin_data]
@@ -288,7 +288,7 @@ macro_rules! stack_pin_init { 
/// # Examples

///

/// ```rust,ignore

/// # #![allow(clippy::disallowed_names, clippy::new_ret_no_self)]

/// # #![allow(clippy::disallowed_names)]

/// # use kernel::{init, pin_init, stack_try_pin_init, init::*, sync::Mutex, new_mutex};

/// # use macros::pin_data;

/// # use core::{alloc::AllocError, pin::Pin};
@@ -314,7 +314,7 @@ macro_rules! stack_pin_init { 
/// ```

///

/// ```rust,ignore

/// # #![allow(clippy::disallowed_names, clippy::new_ret_no_self)]

/// # #![allow(clippy::disallowed_names)]

/// # use kernel::{init, pin_init, stack_try_pin_init, init::*, sync::Mutex, new_mutex};

/// # use macros::pin_data;

/// # use core::{alloc::AllocError, pin::Pin};
@@ -366,7 +366,7 @@ macro_rules! stack_try_pin_init { 
/// The syntax is almost identical to that of a normal `struct` initializer:

///

/// ```rust

/// # #![allow(clippy::disallowed_names, clippy::new_ret_no_self)]

/// # #![allow(clippy::disallowed_names)]

/// # use kernel::{init, pin_init, macros::pin_data, init::*};

/// # use core::pin::Pin;

/// #[pin_data]
@@ -411,7 +411,7 @@ macro_rules! stack_try_pin_init { 
/// To create an initializer function, simply declare it like this:

///

/// ```rust

/// # #![allow(clippy::disallowed_names, clippy::new_ret_no_self)]

/// # #![allow(clippy::disallowed_names)]

/// # use kernel::{init, pin_init, prelude::*, init::*};

/// # use core::pin::Pin;

/// # #[pin_data]
@@ -438,7 +438,7 @@ macro_rules! stack_try_pin_init { 
/// Users of `Foo` can now create it like this:

///

/// ```rust

/// # #![allow(clippy::disallowed_names, clippy::new_ret_no_self)]

/// # #![allow(clippy::disallowed_names)]

/// # use kernel::{init, pin_init, macros::pin_data, init::*};

/// # use core::pin::Pin;

/// # #[pin_data]
@@ -466,7 +466,7 @@ macro_rules! stack_try_pin_init { 
/// They can also easily embed it into their own `struct`s:

///

/// ```rust

/// # #![allow(clippy::disallowed_names, clippy::new_ret_no_self)]

/// # #![allow(clippy::disallowed_names)]

/// # use kernel::{init, pin_init, macros::pin_data, init::*};

/// # use core::pin::Pin;

/// # #[pin_data]

rust/kernel/sync/condvar.rs

+0 −1
Original line number Diff line number Diff line
@@ -91,7 +91,6 @@ unsafe impl Sync for CondVar {} 


impl CondVar {

    /// Constructs a new condvar initialiser.

    #[allow(clippy::new_ret_no_self)]

    pub fn new(name: &'static CStr, key: &'static LockClassKey) -> impl PinInit<Self> {

        pin_init!(Self {

            _pin: PhantomPinned,

rust/kernel/sync/lock.rs

+0 −1
Original line number Diff line number Diff line
@@ -99,7 +99,6 @@ unsafe impl<T: ?Sized + Send, B: Backend> Sync for Lock<T, B> {} 


impl<T, B: Backend> Lock<T, B> {

    /// Constructs a new lock initialiser.

    #[allow(clippy::new_ret_no_self)]

    pub fn new(t: T, name: &'static CStr, key: &'static LockClassKey) -> impl PinInit<Self> {

        pin_init!(Self {

            data: UnsafeCell::new(t),