Unverified Commit b2ec429b authored by Andrew Halaney's avatar Andrew Halaney Committed by Maxime Ripard
Browse files

drm/tidss: Use dev_err_probe() over dev_dbg() when failing to probe the port 



This gets logged out to /sys/kernel/debug/devices_deferred in the
-EPROBE_DEFER case and as an error otherwise. The message here provides
useful information to the user when troubleshooting why their display is
not working in either case, so let's make it output appropriately.

Signed-off-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Tested-by: default avatarEnric Balletbo i Serra <eballetbo@kernel.org>
Link: https://lore.kernel.org/r/20240228-tidss-dev-err-probe-v1-1-5482252326d3@redhat.com


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent e635b7eb

drivers/gpu/drm/tidss/tidss_kms.c

+1 −2
Original line number Diff line number Diff line
@@ -135,8 +135,7 @@ static int tidss_dispc_modeset_init(struct tidss_device *tidss) 
			dev_dbg(dev, "no panel/bridge for port %d\n", i);

			continue;

		} else if (ret) {

			dev_dbg(dev, "port %d probe returned %d\n", i, ret);

			return ret;

			return dev_err_probe(dev, ret, "port %d probe failed\n", i);

		}



		if (panel) {