Commit b3172683 authored by Joe Hattori's avatar Joe Hattori Committed by Rafael J. Wysocki
Browse files

PM: wakeup: implement devm_device_init_wakeup() helper 

Some drivers that enable device wakeup fail to properly disable it
during their cleanup, which results in a memory leak.

To address this, introduce devm_device_init_wakeup(), a managed variant
of device_init_wakeup(dev, true).

With this managed helper, wakeup functionality will be automatically
disabled when the device is released, ensuring a more reliable cleanup
process.

This need for this addition arose during a previous discussion [1].

Link: https://lore.kernel.org/linux-rtc/20241212100403.3799667-1-joe@pf.is.s.u-tokyo.ac.jp/

 [1]
Suggested-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: default avatarJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Link: https://patch.msgid.link/20241218040935.1921416-1-joe@pf.is.s.u-tokyo.ac.jp


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent cb759522

include/linux/pm_wakeup.h

+17 −0
Original line number Diff line number Diff line
@@ -240,4 +240,21 @@ static inline int device_init_wakeup(struct device *dev, bool enable) 
	return 0;

}



static void device_disable_wakeup(void *dev)

{

	device_init_wakeup(dev, false);

}



/**

 * devm_device_init_wakeup - Resource managed device wakeup initialization.

 * @dev: Device to handle.

 *

 * This function is the devm managed version of device_init_wakeup(dev, true).

 */

static inline int devm_device_init_wakeup(struct device *dev)

{

	device_init_wakeup(dev, true);

	return devm_add_action_or_reset(dev, device_disable_wakeup, dev);

}



#endif /* _LINUX_PM_WAKEUP_H */