Commit b33aa90e authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

net: dsa: tag_rzn1_a5psw: use the dsa_xmit_port_mask() helper 



The "a5psw" tagging protocol populates a bit mask for the TX ports,
so we can use dsa_xmit_port_mask() to centralize the decision of how to
set that field.

Cc: "Clément Léger" <clement.leger@bootlin.com>
Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20251127120902.292555-13-vladimir.oltean@nxp.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5afe4ccc

net/dsa/tag_rzn1_a5psw.c

+1 −2
Original line number Diff line number Diff line
@@ -39,7 +39,6 @@ struct a5psw_tag { 


static struct sk_buff *a5psw_tag_xmit(struct sk_buff *skb, struct net_device *dev)

{

	struct dsa_port *dp = dsa_user_to_port(dev);

	struct a5psw_tag *ptag;

	u32 data2_val;
@@ -60,7 +59,7 @@ static struct sk_buff *a5psw_tag_xmit(struct sk_buff *skb, struct net_device *de 


	ptag = dsa_etype_header_pos_tx(skb);



	data2_val = FIELD_PREP(A5PSW_CTRL_DATA_PORT, BIT(dp->index));

	data2_val = FIELD_PREP(A5PSW_CTRL_DATA_PORT, dsa_xmit_port_mask(skb, dev));

	ptag->ctrl_tag = htons(ETH_P_DSA_A5PSW);

	ptag->ctrl_data = htons(A5PSW_CTRL_DATA_FORCE_FORWARD);

	ptag->ctrl_data2_lo = htons(data2_val);